Bug 208503 – Web Inspector: setting the frontend appearance doesn't update the window when undocked

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. detach/undock Web Inspector
3. go to the Settings Tab
4. change the Appearance to the opposite of the system appearance
 => content changes, but the title of the window doesn't

[Devin Rousso]

Created attachment 392253 [details]
Patch

[Timothy Hatcher]

Comment on attachment 392253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392253&action=review

> Source/WebCore/inspector/InspectorFrontendHost.cpp:239
> +            m_frontendPage->setUseDarkAppearanceOverride(false);

You should not need to do this if you force the appearance on the window.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:247
> +            m_frontendPage->setUseDarkAppearanceOverride(true);

Ditto.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:254
>          m_frontendPage->setUseDarkAppearanceOverride(WTF::nullopt);

Ditto.

[Devin Rousso]

Created attachment 392303 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 392303 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 392303 [details]
Patch

Clearing flags on attachment: 392303

Committed r257801: <https://trac.webkit.org/changeset/257801>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/60012509>