Bug 208503 - Web Inspector: setting the frontend appearance doesn't update the window when undocked
Summary: Web Inspector: setting the frontend appearance doesn't update the window when...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on: 186308
Blocks: 208557
  Show dependency treegraph
Reported: 2020-03-03 00:07 PST by Devin Rousso
Modified: 2020-03-03 20:52 PST (History)
7 users (show)

See Also:

Patch (30.74 KB, patch)
2020-03-03 01:04 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (30.66 KB, patch)
2020-03-03 11:33 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-03-03 00:07:34 PST
1. inspect any page
2. detach/undock Web Inspector
3. go to the Settings Tab
4. change the Appearance to the opposite of the system appearance
 => content changes, but the title of the window doesn't
Comment 1 Devin Rousso 2020-03-03 01:04:34 PST
Created attachment 392253 [details]
Comment 2 Timothy Hatcher 2020-03-03 09:54:20 PST
Comment on attachment 392253 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=392253&action=review

> Source/WebCore/inspector/InspectorFrontendHost.cpp:239
> +            m_frontendPage->setUseDarkAppearanceOverride(false);

You should not need to do this if you force the appearance on the window.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:247
> +            m_frontendPage->setUseDarkAppearanceOverride(true);


> Source/WebCore/inspector/InspectorFrontendHost.cpp:254
>          m_frontendPage->setUseDarkAppearanceOverride(WTF::nullopt);

Comment 3 Devin Rousso 2020-03-03 11:33:27 PST
Created attachment 392303 [details]
Comment 4 WebKit Commit Bot 2020-03-03 14:10:52 PST
The commit-queue encountered the following flaky tests while processing attachment 392303 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-03-03 14:11:35 PST
Comment on attachment 392303 [details]

Clearing flags on attachment: 392303

Committed r257801: <https://trac.webkit.org/changeset/257801>
Comment 6 WebKit Commit Bot 2020-03-03 14:11:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-03-03 14:12:21 PST