Bug 208502 - Web Inspector: the execution context picker is shown on pages with only one execution context if there are internal execution contexts
Summary: Web Inspector: the execution context picker is shown on pages with only one e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL: https://devinrousso.com/demo/WebKit/s...
Keywords: InRadar
Depends on: 206110
Blocks:
  Show dependency tree / graph
 
Reported: 2020-03-02 23:57 PST by Devin Rousso
Modified: 2020-03-04 12:48 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2020-03-03 00:13 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-03-02 23:57:25 PST 
# STEPS TO REPRODUCE:
1. inspect <https://devinrousso.com/demo/WebKit/stream_of_water.html>
=> the execution context picker is shown with:
    * Auto - stream_of_water.html
    -----
    * stream_of_water.html

This is because the page also has internal execution contexts, which are currently incorrectly counted when determining whether to show the execution context picker (we shouldn't show it if there is only one execution context).  For non-engineering builds, internal execution contexts should be ignored.
Comment 1 Devin Rousso 2020-03-03 00:13:17 PST 
Created attachment 392252 [details]
Patch
Comment 2 WebKit Commit Bot 2020-03-04 12:46:47 PST 
The commit-queue encountered the following flaky tests while processing attachment 392252 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2020-03-04 12:47:29 PST 
Comment on attachment 392252 [details]
Patch

Clearing flags on attachment: 392252

Committed r257873: <https://trac.webkit.org/changeset/257873>
Comment 4 WebKit Commit Bot 2020-03-04 12:47:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-04 12:48:16 PST 
<rdar://problem/60052184>