Bug 208463 - Annotate editable elements with hit test order
Summary: Annotate editable elements with hit test order
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 13
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 209561
  Show dependency treegraph
 
Reported: 2020-03-02 12:34 PST by Daniel Bates
Modified: 2020-03-25 13:55 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.38 KB, patch)
2020-03-02 13:01 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (7.41 KB, patch)
2020-03-02 13:26 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
To land (7.45 KB, patch)
2020-03-02 16:58 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-03-02 12:34:39 PST
Until <rdar://problem/59737118> is fixed, annotate editable elements with their paint order towards fixing <rdar://problem/59602885>.
Comment 1 Radar WebKit Bug Importer 2020-03-02 12:34:51 PST
<rdar://problem/59962843>
Comment 2 Daniel Bates 2020-03-02 13:01:52 PST
Created attachment 392176 [details]
Patch
Comment 3 Daniel Bates 2020-03-02 13:25:11 PST
Comment on attachment 392176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392176&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKTextInputContextInternal.h:39
> +- (NSUInteger)_paintOrder;

Should be @property
Comment 4 Daniel Bates 2020-03-02 13:26:20 PST
Created attachment 392179 [details]
Patch
Comment 5 Wenson Hsieh 2020-03-02 14:21:31 PST
Comment on attachment 392179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392179&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6834
> +        context.paintOrder = count++;

Nit: IMO, "hitTestingOrder" would be a more relevant name, since this index is directly influenced by the order of elements as they are hit-tested (which, in turn, depends on their painting order).
Comment 6 Daniel Bates 2020-03-02 16:58:21 PST
Created attachment 392215 [details]
To land
Comment 7 Daniel Bates 2020-03-02 16:59:18 PST
Committed r257749: <https://trac.webkit.org/changeset/257749>