Bug 208442 – [GTK][WPE] Fix current time and duration formatting in media controls

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

We are always using mm:ss for current time and duration. We should use different amount of digits depending on the duration:

m:ss <- duration < 10 minutes
mm:ss <- duration < 1 hour
h:mm:ss <- duration < 10 hours
hh:mm:ss <- duration >= 10 hours

[Carlos Garcia Campos]

Created attachment 392128 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 392128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392128&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411
> +        else if (duration < 10 * 60) /* Ten minutes */
> +            this.timeDigitsCount = 3;

I personally dislike having this on a time display. I would strongly recommend you remove this or run it thru more people who can give an opinion on this.

[Carlos Garcia Campos]

(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 392128 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392128&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411
> > +        else if (duration < 10 * 60) /* Ten minutes */
> > +            this.timeDigitsCount = 3;
> 
> I personally dislike having this on a time display. I would strongly
> recommend you remove this or run it thru more people who can give an opinion
> on this.

What do you mean? You don't like m:ss and h:mm:ss?

[Xabier Rodríguez Calvar]

(In reply to Carlos Garcia Campos from comment #3)
> (In reply to Xabier Rodríguez Calvar from comment #2)
> > Comment on attachment 392128 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=392128&action=review
> > 
> > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411
> > > +        else if (duration < 10 * 60) /* Ten minutes */
> > > +            this.timeDigitsCount = 3;
> > 
> > I personally dislike having this on a time display. I would strongly
> > recommend you remove this or run it thru more people who can give an opinion
> > on this.
> 
> What do you mean? You don't like m:ss and h:mm:ss?

I don't like m:ss but I don't mind h:mm:ss. That was the design choice and I don't see a reason why it should not be respected now as well.

[Carlos Garcia Campos]

(In reply to Xabier Rodríguez Calvar from comment #4)
> (In reply to Carlos Garcia Campos from comment #3)
> > (In reply to Xabier Rodríguez Calvar from comment #2)
> > > Comment on attachment 392128 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=392128&action=review
> > > 
> > > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411
> > > > +        else if (duration < 10 * 60) /* Ten minutes */
> > > > +            this.timeDigitsCount = 3;
> > > 
> > > I personally dislike having this on a time display. I would strongly
> > > recommend you remove this or run it thru more people who can give an opinion
> > > on this.
> > 
> > What do you mean? You don't like m:ss and h:mm:ss?
> 
> I don't like m:ss but I don't mind h:mm:ss. That was the design choice and I
> don't see a reason why it should not be respected now as well.

For consistency with other browsers, GNOME and some other popular video players.

[Carlos Garcia Campos]

Committed r257778: <https://trac.webkit.org/changeset/257778>