Bug 208439 - JSC 32bits broken in debug mode by r257399
Summary: JSC 32bits broken in debug mode by r257399
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Paulo Matos
URL:
Keywords: InRadar
Depends on:
Blocks: 208048
  Show dependency tree / graph
 
Reported: 2020-03-02 03:12 PST by Paulo Matos
Modified: 2020-03-04 10:22 PST (History)
10 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2020-03-02 04:49 PST, Paulo Matos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paulo Matos 2020-03-02 03:12:02 PST 
Commit 257399 (bug 207522) breaks 32bit builds in debug mode due to assert calling JSC::JSValueRegs::gpr()

../../Source/JavaScriptCore/bytecode/AccessCase.cpp:1945:41: error: no matching function for call to ‘JSC::JSValueRegs::gpr()’
         ASSERT(baseGPR != valueRegs.gpr());
Comment 1 Paulo Matos 2020-03-02 04:49:38 PST 
Created attachment 392131 [details]
Patch
Comment 2 Caio Lima 2020-03-02 07:15:38 PST 
Comment on attachment 392131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392131&action=review

LGTM

> Source/JavaScriptCore/bytecode/AccessCase.cpp:1947
> +        ASSERT(!valueRegs.uses(scratchGPR));

Nice catch.
Comment 3 Paulo Matos 2020-03-04 02:51:46 PST 
ping!
Comment 4 WebKit Commit Bot 2020-03-04 10:21:54 PST 
Comment on attachment 392131 [details]
Patch

Clearing flags on attachment: 392131

Committed r257856: <https://trac.webkit.org/changeset/257856>
Comment 5 WebKit Commit Bot 2020-03-04 10:21:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-04 10:22:16 PST 
<rdar://problem/60045082>