Bug 208423 – [GPUP] Plumb through more MediaPlayer methods

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Plumb through more MediaPlayer methods when media is loaded in the GPU process.

[Radar WebKit Bug Importer]

<rdar://problem/59924386>

[Eric Carlson]

Created attachment 392084 [details]
Patch

[Eric Carlson]

Created attachment 392089 [details]
Patch

[Eric Carlson]

Created attachment 392093 [details]
Patch

[youenn fablet]

Comment on attachment 392093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392093&action=review

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:279
> +    m_cachedState.didPassCORSAccessCheck = m_player->didPassCORSAccessCheck();

Should some of these state updates being added to updateCachedState(), for instance wirelessVideoPlaybackDisabled()?
Should we always resync all values for extra safety?

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:675
> +    if (!connection().sendSync(Messages::RemoteMediaPlayerProxy::AccessLog(m_id), Messages::RemoteMediaPlayerProxy::AccessLog::Reply(log), m_id))

Seems to make this fail on iOS since AccessLog is not defined for RemoteMediaPlayerProxy.

[Eric Carlson]

Comment on attachment 392093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392093&action=review

>> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:279
>> +    m_cachedState.didPassCORSAccessCheck = m_player->didPassCORSAccessCheck();
> 
> Should some of these state updates being added to updateCachedState(), for instance wirelessVideoPlaybackDisabled()?
> Should we always resync all values for extra safety?

I don't think we want to update all of these in updateCachedState because it is called so frequently

I tried to make sure every cached state is updated in the appropriate media player callback. For example, m_cachedState.wirelessVideoPlaybackDisabled and m_cachedState.wirelessPlaybackTargetName are updated in RemoteMediaPlayerProxy::mediaPlayerCurrentPlaybackTargetIsWirelessChanged if the framework changes @externalPlaybackActive or @allowsExternalPlayback.

[Eric Carlson]

Created attachment 392135 [details]
Patch

[Eric Carlson]

Created attachment 392138 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 392138 [details]
Patch

Clearing flags on attachment: 392138

Committed r257711: <https://trac.webkit.org/changeset/257711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Carlson]

Reopening to attach new patch.

[Eric Carlson]

Created attachment 392159 [details]
Patch

[Eric Carlson]

Created attachment 392160 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 392160 [details]
Patch

Clearing flags on attachment: 392160

Committed r257724: <https://trac.webkit.org/changeset/257724>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.