Plumb through more MediaPlayer methods when media is loaded in the GPU process.
<rdar://problem/59924386>
Created attachment 392084 [details] Patch
Created attachment 392089 [details] Patch
Created attachment 392093 [details] Patch
Comment on attachment 392093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392093&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:279 > + m_cachedState.didPassCORSAccessCheck = m_player->didPassCORSAccessCheck(); Should some of these state updates being added to updateCachedState(), for instance wirelessVideoPlaybackDisabled()? Should we always resync all values for extra safety? > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:675 > + if (!connection().sendSync(Messages::RemoteMediaPlayerProxy::AccessLog(m_id), Messages::RemoteMediaPlayerProxy::AccessLog::Reply(log), m_id)) Seems to make this fail on iOS since AccessLog is not defined for RemoteMediaPlayerProxy.
Comment on attachment 392093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392093&action=review >> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:279 >> + m_cachedState.didPassCORSAccessCheck = m_player->didPassCORSAccessCheck(); > > Should some of these state updates being added to updateCachedState(), for instance wirelessVideoPlaybackDisabled()? > Should we always resync all values for extra safety? I don't think we want to update all of these in updateCachedState because it is called so frequently I tried to make sure every cached state is updated in the appropriate media player callback. For example, m_cachedState.wirelessVideoPlaybackDisabled and m_cachedState.wirelessPlaybackTargetName are updated in RemoteMediaPlayerProxy::mediaPlayerCurrentPlaybackTargetIsWirelessChanged if the framework changes @externalPlaybackActive or @allowsExternalPlayback.
Created attachment 392135 [details] Patch
Created attachment 392138 [details] Patch
Comment on attachment 392138 [details] Patch Clearing flags on attachment: 392138 Committed r257711: <https://trac.webkit.org/changeset/257711>
All reviewed patches have been landed. Closing bug.
Reopening to attach new patch.
Created attachment 392159 [details] Patch
Created attachment 392160 [details] Patch
Comment on attachment 392160 [details] Patch Clearing flags on attachment: 392160 Committed r257724: <https://trac.webkit.org/changeset/257724>