RESOLVED FIXED208419
[LFC][MarginCollapsing] Do not re-compute PositiveAndNegativeVerticalMargin values 
https://bugs.webkit.org/show_bug.cgi?id=208419
Summary [LFC][MarginCollapsing] Do not re-compute PositiveAndNegativeVerticalMargin v...
alan
Reported 2020-02-29 16:18:53 PST
ssia
Attachments
Patch (14.35 KB, patch)
2020-02-29 16:22 PST, alan 		zalan: commit-queue+
DetailsFormatted DiffDiff
Patch (14.29 KB, patch)
2020-03-01 08:22 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-29 16:19:10 PST
<rdar://problem/59923666>
alan
Comment 2 2020-02-29 16:22:06 PST
Created attachment 392079 [details] Patch
Antti Koivisto
Comment 3 2020-02-29 21:58:59 PST
Comment on attachment 392079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392079&action=review > Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:588 > + auto beforeMarginIsCollapsed = marginBeforeCollapsesWithFirstInFlowChildMarginBefore(layoutBox) || marginBeforeCollapsesWithPreviousSiblingMarginAfter(layoutBox); hasCollapsedMarginBefore may read better.
alan
Comment 4 2020-03-01 08:22:58 PST
Created attachment 392097 [details] Patch
alan
Comment 5 2020-03-01 08:23:13 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 392079 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392079&action=review > > > Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:588 > > + auto beforeMarginIsCollapsed = marginBeforeCollapsesWithFirstInFlowChildMarginBefore(layoutBox) || marginBeforeCollapsesWithPreviousSiblingMarginAfter(layoutBox); > > hasCollapsedMarginBefore may read better. Indeed!
WebKit Commit Bot
Comment 6 2020-03-01 09:56:02 PST
Comment on attachment 392097 [details] Patch Clearing flags on attachment: 392097 Committed r257690: <https://trac.webkit.org/changeset/257690>
WebKit Commit Bot
Comment 7 2020-03-01 09:56:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.