ssia
<rdar://problem/59923666>
Created attachment 392079 [details] Patch
Comment on attachment 392079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392079&action=review > Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:588 > + auto beforeMarginIsCollapsed = marginBeforeCollapsesWithFirstInFlowChildMarginBefore(layoutBox) || marginBeforeCollapsesWithPreviousSiblingMarginAfter(layoutBox); hasCollapsedMarginBefore may read better.
Created attachment 392097 [details] Patch
(In reply to Antti Koivisto from comment #3) > Comment on attachment 392079 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392079&action=review > > > Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:588 > > + auto beforeMarginIsCollapsed = marginBeforeCollapsesWithFirstInFlowChildMarginBefore(layoutBox) || marginBeforeCollapsesWithPreviousSiblingMarginAfter(layoutBox); > > hasCollapsedMarginBefore may read better. Indeed!
Comment on attachment 392097 [details] Patch Clearing flags on attachment: 392097 Committed r257690: <https://trac.webkit.org/changeset/257690>
All reviewed patches have been landed. Closing bug.