RESOLVED FIXED 208417
Simplify gradient parsing 
https://bugs.webkit.org/show_bug.cgi?id=208417
Summary Simplify gradient parsing
Darin Adler
Reported 2020-02-29 14:15:39 PST
Simplify gradient parsing code
Attachments
Patch (72.46 KB, patch)
2020-02-29 15:03 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (72.66 KB, patch)
2020-03-01 16:38 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (72.77 KB, patch)
2020-03-01 18:56 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (73.74 KB, patch)
2020-03-03 09:12 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (73.74 KB, patch)
2020-03-04 21:00 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-02-29 15:03:16 PST
Created attachment 392073 [details] Patch
Anders Carlsson
Comment 2 2020-02-29 15:12:49 PST
Comment on attachment 392073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392073&action=review > Source/WebCore/ChangeLog:8 > + - Use Optional<> and invalid Color to reprsent unspecified positions and colors. Typo "reprsent".
Darin Adler
Comment 3 2020-03-01 16:38:37 PST
Created attachment 392108 [details] Patch
Darin Adler
Comment 4 2020-03-01 16:39:24 PST
I’ll land this after EWS confirms I fixed the "use after move" mistake in my earlier patch that was screwing up parsing some gradients.
Darin Adler
Comment 5 2020-03-01 18:56:24 PST
Created attachment 392115 [details] Patch
Darin Adler
Comment 6 2020-03-03 09:12:22 PST
Created attachment 392283 [details] Patch
Darin Adler
Comment 7 2020-03-04 21:00:30 PST
Created attachment 392533 [details] Patch
Darin Adler
Comment 8 2020-03-05 20:11:45 PST
Committed r257966: <https://trac.webkit.org/changeset/257966>
Radar WebKit Bug Importer
Comment 9 2020-03-05 20:12:16 PST
<rdar://problem/60118479>
Note You need to log in before you can comment on or make changes to this bug.