Bug 208417 - Simplify gradient parsing
Summary: Simplify gradient parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-29 14:15 PST by Darin Adler
Modified: 2020-03-05 20:12 PST (History)
10 users (show)

See Also:


Attachments
Patch (72.46 KB, patch)
2020-02-29 15:03 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (72.66 KB, patch)
2020-03-01 16:38 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (72.77 KB, patch)
2020-03-01 18:56 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (73.74 KB, patch)
2020-03-03 09:12 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (73.74 KB, patch)
2020-03-04 21:00 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-02-29 14:15:39 PST
Simplify gradient parsing code
Comment 1 Darin Adler 2020-02-29 15:03:16 PST
Created attachment 392073 [details]
Patch
Comment 2 Anders Carlsson 2020-02-29 15:12:49 PST
Comment on attachment 392073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392073&action=review

> Source/WebCore/ChangeLog:8
> +        - Use Optional<> and invalid Color to reprsent unspecified positions and colors.

Typo "reprsent".
Comment 3 Darin Adler 2020-03-01 16:38:37 PST
Created attachment 392108 [details]
Patch
Comment 4 Darin Adler 2020-03-01 16:39:24 PST
I’ll land this after EWS confirms I fixed the "use after move" mistake in my earlier patch that was screwing up parsing some gradients.
Comment 5 Darin Adler 2020-03-01 18:56:24 PST
Created attachment 392115 [details]
Patch
Comment 6 Darin Adler 2020-03-03 09:12:22 PST
Created attachment 392283 [details]
Patch
Comment 7 Darin Adler 2020-03-04 21:00:30 PST
Created attachment 392533 [details]
Patch
Comment 8 Darin Adler 2020-03-05 20:11:45 PST
Committed r257966: <https://trac.webkit.org/changeset/257966>
Comment 9 Radar WebKit Bug Importer 2020-03-05 20:12:16 PST
<rdar://problem/60118479>