Bug 208416 - Regression r257645: Windows build broken
Summary: Regression r257645: Windows build broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-29 09:23 PST by Aakash Jain
Modified: 2020-02-29 10:05 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-02-29 09:23:10 PST 
Windows build seems to be broken by r257645.

e.g.:
Source\WebKitLegacy\win\FullscreenVideoController.cpp(212,52): error C2039: 'platformCALayer': is not a member of 'WebCore::PlatformCALayer' 
WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore\PlatformCALayer.h(50): message : see declaration of 'WebCore::PlatformCALayer' Source\WebKitLegacy\win\FullscreenVideoController.cpp(212,67): error C3861: 'platformCALayer': identifier not found 
Source\WebKitLegacy\win\FullscreenVideoController.cpp(293,52): error C2039: 'platformCALayer': is not a member of 'WebCore::PlatformCALayer' 


r257644 passed in https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Build%29/builds/10778
r257647 failed in https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Build%29/builds/10779


EWS also indicated this failure in the corresponding bug https://bugs.webkit.org/show_bug.cgi?id=208358
Comment 1 Radar WebKit Bug Importer 2020-02-29 09:23:56 PST 
<rdar://problem/59919739>
Comment 2 Simon Fraser (smfr) 2020-02-29 10:01:17 PST 
Actually:
C:\cygwin\worker\win10-release\build\Source\WebKitLegacy\win\WebView.cpp(7274,65): error C2039: 'platformCALayer': is not a member of 'WebCore::PlatformCALayer' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
C:\cygwin\worker\win10-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/PlatformCALayer.h(50): message : see declaration of 'WebCore::PlatformCALayer' [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
C:\cygwin\worker\win10-release\build\Source\WebKitLegacy\win\WebView.cpp(7274,80): error C3861: 'platformCALayer': identifier not found [C:\cygwin\worker\win10-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
Comment 3 Simon Fraser (smfr) 2020-02-29 10:05:53 PST 
https://trac.webkit.org/changeset/257684/webkit