Bug 208415 - [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
Summary: [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on: 208513
Blocks:
  Show dependency tree / graph
 
Reported: 2020-02-29 08:49 PST by Per Arne Vollan
Modified: 2020-03-09 12:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.43 KB, patch)
2020-02-29 09:06 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (18.98 KB, patch)
2020-02-29 09:29 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.18 KB, patch)
2020-02-29 12:19 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.37 KB, patch)
2020-02-29 13:32 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (19.71 KB, patch)
2020-02-29 15:53 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.92 KB, patch)
2020-03-02 10:49 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.92 KB, patch)
2020-03-02 11:06 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.97 KB, patch)
2020-03-02 16:12 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (20.02 KB, patch)
2020-03-02 17:47 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.14 KB, patch)
2020-03-03 07:55 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.21 KB, patch)
2020-03-03 08:02 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.53 KB, patch)
2020-03-03 10:53 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.55 KB, patch)
2020-03-03 12:27 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.49 KB, patch)
2020-03-03 14:30 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.66 KB, patch)
2020-03-03 16:00 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (19.62 KB, patch)
2020-03-03 17:19 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-02-29 08:49:11 PST 
This is currently done in the WebContent process, but since this is using a system service which will be closed, this mapping should be moved to the UI process.
Comment 1 Per Arne Vollan 2020-02-29 09:06:14 PST 
Created attachment 392062 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-02-29 09:06:47 PST 
<rdar://problem/59919609>
Comment 3 Per Arne Vollan 2020-02-29 09:29:37 PST 
Created attachment 392065 [details]
Patch
Comment 4 Per Arne Vollan 2020-02-29 12:19:54 PST 
Created attachment 392069 [details]
Patch
Comment 5 Per Arne Vollan 2020-02-29 13:32:04 PST 
Created attachment 392070 [details]
Patch
Comment 6 Per Arne Vollan 2020-02-29 15:53:40 PST 
Created attachment 392077 [details]
Patch
Comment 7 Per Arne Vollan 2020-02-29 15:54:40 PST 
Thanks for reviewing!
Comment 8 WebKit Commit Bot 2020-02-29 19:31:46 PST 
The commit-queue encountered the following flaky tests while processing attachment 392077 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-02-29 19:32:21 PST 
Comment on attachment 392077 [details]
Patch

Clearing flags on attachment: 392077

Committed r257687: <https://trac.webkit.org/changeset/257687>
Comment 11 Jacob Uphoff 2020-03-02 08:13:37 PST 
Reverted r257687 for reason:

This commit caused debug tests to crash for macOS & iOS

Committed r257713: <https://trac.webkit.org/changeset/257713>
Comment 12 Per Arne Vollan 2020-03-02 10:49:24 PST 
Created attachment 392153 [details]
Patch
Comment 13 Per Arne Vollan 2020-03-02 11:06:52 PST 
Created attachment 392156 [details]
Patch
Comment 14 WebKit Commit Bot 2020-03-02 12:21:38 PST 
Comment on attachment 392156 [details]
Patch

Clearing flags on attachment: 392156

Committed r257725: <https://trac.webkit.org/changeset/257725>
Comment 15 Jacob Uphoff 2020-03-02 15:59:02 PST 
Reverted r257725 for reason:

This commit caused 10 API tests to fail

Committed r257745: <https://trac.webkit.org/changeset/257745>
Comment 16 Per Arne Vollan 2020-03-02 16:12:44 PST 
Created attachment 392210 [details]
Patch
Comment 17 Per Arne Vollan 2020-03-02 17:47:04 PST 
Created attachment 392231 [details]
Patch
Comment 18 WebKit Commit Bot 2020-03-02 18:37:40 PST 
Comment on attachment 392231 [details]
Patch

Clearing flags on attachment: 392231

Committed r257754: <https://trac.webkit.org/changeset/257754>
Comment 19 Aakash Jain 2020-03-03 05:05:21 PST 
(In reply to WebKit Commit Bot from comment #18)
> Committed r257754: <https://trac.webkit.org/changeset/257754>
This seems to have broken API test: TestWebKitAPI.DragAndDropTests.CanStartDragOnEnormousImage, Tracked in Bug 208508.

EWS also warned about this failure in https://ews-build.webkit.org/#/builders/9/builds/18618
Comment 20 Per Arne Vollan 2020-03-03 07:55:51 PST 
Created attachment 392275 [details]
Patch
Comment 21 Per Arne Vollan 2020-03-03 08:02:27 PST 
Created attachment 392277 [details]
Patch
Comment 22 Per Arne Vollan 2020-03-03 10:53:57 PST 
Created attachment 392298 [details]
Patch
Comment 23 Per Arne Vollan 2020-03-03 12:27:52 PST 
Created attachment 392309 [details]
Patch
Comment 24 Per Arne Vollan 2020-03-03 14:30:51 PST 
Created attachment 392331 [details]
Patch
Comment 25 Per Arne Vollan 2020-03-03 16:00:36 PST 
Created attachment 392345 [details]
Patch
Comment 26 Per Arne Vollan 2020-03-03 17:19:00 PST 
Created attachment 392355 [details]
Patch
Comment 27 WebKit Commit Bot 2020-03-03 21:13:07 PST 
Comment on attachment 392355 [details]
Patch

Clearing flags on attachment: 392355

Committed r257828: <https://trac.webkit.org/changeset/257828>