Bug 208409 - The patch added in bug 138420 was dropped during updating gtest
Summary: The patch added in bug 138420 was dropped during updating gtest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-29 01:24 PST by Ting-Wei Lan
Modified: 2020-03-01 10:25 PST (History)
3 users (show)

See Also:

Attachments
Patch for gtest (2.73 KB, patch)
2020-02-29 01:26 PST, Ting-Wei Lan 		no flags Details | Formatted Diff | Diff
Patch for gtest (5.27 KB, patch)
2020-02-29 20:06 PST, Ting-Wei Lan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2020-02-29 01:24:49 PST 
Without the patch, gtest can't be built on FreeBSD with -Wl,--no-undefined because of its use of 'environ' variable. I will attach a patch to re-add it.
Comment 1 Ting-Wei Lan 2020-02-29 01:26:27 PST 
Created attachment 392053 [details]
Patch for gtest
Comment 2 Michael Catanzaro 2020-02-29 14:39:20 PST 
Comment on attachment 392053 [details]
Patch for gtest

Can you please add a README.webkit and a changes.diff (patch file) to document the changes? Otherwise it's just going to be lost again next update.
Comment 3 Ting-Wei Lan 2020-02-29 20:06:44 PST 
Created attachment 392090 [details]
Patch for gtest
Comment 4 WebKit Commit Bot 2020-03-01 10:24:34 PST 
Comment on attachment 392090 [details]
Patch for gtest

Clearing flags on attachment: 392090

Committed r257691: <https://trac.webkit.org/changeset/257691>
Comment 5 WebKit Commit Bot 2020-03-01 10:24:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-01 10:25:16 PST 
<rdar://problem/59930856>