Bug 208387 - Adopt HTTP Alternative Services Storage
Summary: Adopt HTTP Alternative Services Storage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-28 12:53 PST by jmehta
Modified: 2020-03-03 10:22 PST (History)
10 users (show)

See Also:

Attachments
Proposed changes for HTTP Alternative Services (15.98 KB, patch)
2020-02-28 12:57 PST, jmehta 		no flags Details | Formatted Diff | Diff
Proposed changes for HTTP Alternative Services (15.99 KB, patch)
2020-02-28 13:58 PST, jmehta 		no flags Details | Formatted Diff | Diff
Patch (31.53 KB, patch)
2020-03-02 16:23 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (31.53 KB, patch)
2020-03-02 17:06 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (35.05 KB, patch)
2020-03-02 23:31 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (39.88 KB, patch)
2020-03-03 09:34 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jmehta 2020-02-28 12:53:46 PST 
rdar://problem/56994565
Comment 1 jmehta 2020-02-28 12:57:05 PST 
Created attachment 392007 [details]
Proposed changes for HTTP Alternative Services
Comment 2 jmehta 2020-02-28 13:58:18 PST 
Created attachment 392016 [details]
Proposed changes for HTTP Alternative Services
Comment 3 Maciej Stachowiak 2020-02-29 14:17:15 PST 
Besides I breaking the build, we need to verify that this doesn’t create a potential supercookie like HSTS did, that it’s cleared by clearing website data, etc.
Comment 4 Alex Christensen 2020-02-29 14:19:19 PST 
Comment on attachment 392016 [details]
Proposed changes for HTTP Alternative Services

This needs a new HAVE_ALTERNATIVE_SERVICES macro in Platform.h to not break the build.
We will also need SPI on _WKWebsiteDataStoreConfiguration to specify the storage file location.
Comment 5 Alex Christensen 2020-03-02 16:23:27 PST 
Created attachment 392211 [details]
Patch
Comment 6 Alex Christensen 2020-03-02 17:06:07 PST 
Created attachment 392220 [details]
patch
Comment 7 Alex Christensen 2020-03-02 23:31:23 PST 
Created attachment 392251 [details]
Patch
Comment 8 Alex Christensen 2020-03-03 09:34:55 PST 
Created attachment 392285 [details]
Patch
Comment 9 WebKit Commit Bot 2020-03-03 10:21:22 PST 
Comment on attachment 392285 [details]
Patch

Clearing flags on attachment: 392285

Committed r257785: <https://trac.webkit.org/changeset/257785>
Comment 10 WebKit Commit Bot 2020-03-03 10:21:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2020-03-03 10:22:26 PST 
<rdar://problem/60001847>