Bug 208363 - Fix WebCore export macros for declspec
Summary: Fix WebCore export macros for declspec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-27 17:39 PST by Don Olmstead
Modified: 2020-02-27 22:26 PST (History)
7 users (show)

See Also:


Attachments
Patch (7.84 KB, patch)
2020-02-27 17:43 PST, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (20.37 KB, patch)
2020-02-27 19:24 PST, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (20.37 KB, patch)
2020-02-27 19:33 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-02-27 17:39:16 PST
Currently WEBCORE_EXPORT on Windows is set using header files rather than being configured based on the library type. The PlatformExportMacros file should match the other export files and not have Windows specific logic.
Comment 1 Don Olmstead 2020-02-27 17:43:59 PST
Created attachment 391948 [details]
Patch
Comment 2 Don Olmstead 2020-02-27 17:44:36 PST
Comment on attachment 391948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391948&action=review

> Source/WebCore/WebCorePrefix.h:44
> +#if !PLATFORM(WIN)

Should be !OS(WINDOWS)
Comment 3 Konstantin Tokarev 2020-02-27 17:51:30 PST
Comment on attachment 391948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391948&action=review

> Tools/TestWebKitAPI/win/TestWebKitAPIPrefix.h:-32
> -#define WEBCORE_TESTSUPPORT_EXPORT

After this change, this file contains only copyright header. Shouldn't it be removed altogether?

> Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:-29
> -#define WEBCORE_TESTSUPPORT_EXPORT

Ditto.
Comment 4 Don Olmstead 2020-02-27 19:24:34 PST
Created attachment 391957 [details]
Patch
Comment 5 Konstantin Tokarev 2020-02-27 19:31:51 PST
Comment on attachment 391957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391957&action=review

> Source/WebCore/WebCorePrefix.h:46
> +#endif // !OS(WIN)

Typo
Comment 6 Don Olmstead 2020-02-27 19:33:45 PST
Created attachment 391958 [details]
Patch
Comment 7 WebKit Commit Bot 2020-02-27 22:25:11 PST
The commit-queue encountered the following flaky tests while processing attachment 391958 [details]:

editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-02-27 22:25:56 PST
Comment on attachment 391958 [details]
Patch

Clearing flags on attachment: 391958

Committed r257619: <https://trac.webkit.org/changeset/257619>
Comment 9 WebKit Commit Bot 2020-02-27 22:25:58 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-02-27 22:26:15 PST
<rdar://problem/59877365>