Currently WEBCORE_EXPORT on Windows is set using header files rather than being configured based on the library type. The PlatformExportMacros file should match the other export files and not have Windows specific logic.
Created attachment 391948 [details] Patch
Comment on attachment 391948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391948&action=review > Source/WebCore/WebCorePrefix.h:44 > +#if !PLATFORM(WIN) Should be !OS(WINDOWS)
Comment on attachment 391948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391948&action=review > Tools/TestWebKitAPI/win/TestWebKitAPIPrefix.h:-32 > -#define WEBCORE_TESTSUPPORT_EXPORT After this change, this file contains only copyright header. Shouldn't it be removed altogether? > Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:-29 > -#define WEBCORE_TESTSUPPORT_EXPORT Ditto.
Created attachment 391957 [details] Patch
Comment on attachment 391957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391957&action=review > Source/WebCore/WebCorePrefix.h:46 > +#endif // !OS(WIN) Typo
Created attachment 391958 [details] Patch
The commit-queue encountered the following flaky tests while processing attachment 391958 [details]: editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 391958 [details] Patch Clearing flags on attachment: 391958 Committed r257619: <https://trac.webkit.org/changeset/257619>
All reviewed patches have been landed. Closing bug.
<rdar://problem/59877365>