WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
208346
[iOS] Remove logging for sysctl access to properties used by NSURLSession
https://bugs.webkit.org/show_bug.cgi?id=208346
Summary
[iOS] Remove logging for sysctl access to properties used by NSURLSession
Brent Fulgham
Reported
2020-02-27 15:40:30 PST
Telemetry and logging indicate that two sysctl calls are needed by [NSURLSession sessionWithConfiguration]. We should allow this access so that it can make appropriate decisions about the network stack for the current device: kern.ostype kern.osrelease
Attachments
Patch
(2.03 KB, patch)
2020-02-27 15:45 PST
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2020-02-27 15:40:51 PST
<
rdar://problem/59862967
>
Brent Fulgham
Comment 2
2020-02-27 15:45:07 PST
Created
attachment 391936
[details]
Patch
Alexey Proskuryakov
Comment 3
2020-02-27 17:54:23 PST
Comment on
attachment 391936
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=391936&action=review
> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:570 > + "kern.ostype" ;; Needed by NSURLSession
I find these comments to not be very useful in the long term. Certainly such low level functionality is needed - or will be needed - by a lot of frameworks. So not sure what information a future reader will get from the fact that back in 2020, we first noticed it to be used by this particular one.
WebKit Commit Bot
Comment 4
2020-02-27 19:50:19 PST
Comment on
attachment 391936
[details]
Patch Clearing flags on attachment: 391936 Committed
r257615
: <
https://trac.webkit.org/changeset/257615
>
WebKit Commit Bot
Comment 5
2020-02-27 19:50:20 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug