Bug 208346 - [iOS] Remove logging for sysctl access to properties used by NSURLSession
Summary: [iOS] Remove logging for sysctl access to properties used by NSURLSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-27 15:40 PST by Brent Fulgham
Modified: 2020-02-27 19:50 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2020-02-27 15:45 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-02-27 15:40:30 PST 
Telemetry and logging indicate that two sysctl calls are needed by [NSURLSession sessionWithConfiguration]. We should allow this access so that it can make appropriate decisions about the network stack for the current device:

kern.ostype
kern.osrelease
Comment 1 Brent Fulgham 2020-02-27 15:40:51 PST 
<rdar://problem/59862967>
Comment 2 Brent Fulgham 2020-02-27 15:45:07 PST 
Created attachment 391936 [details]
Patch
Comment 3 Alexey Proskuryakov 2020-02-27 17:54:23 PST 
Comment on attachment 391936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391936&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:570
> +        "kern.ostype" ;; Needed by NSURLSession

I find these comments to not be very useful in the long term. Certainly such low level functionality is needed - or will be needed - by a lot of frameworks. So not sure what information a future reader will get from the fact that back in 2020, we first noticed it to be used by this particular one.
Comment 4 WebKit Commit Bot 2020-02-27 19:50:19 PST 
Comment on attachment 391936 [details]
Patch

Clearing flags on attachment: 391936

Committed r257615: <https://trac.webkit.org/changeset/257615>
Comment 5 WebKit Commit Bot 2020-02-27 19:50:20 PST 
All reviewed patches have been landed.  Closing bug.