Bug 208329 - [ews] commit queue should skip building and testing for rollout patches
Summary: [ews] commit queue should skip building and testing for rollout patches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-27 10:40 PST by Aakash Jain
Modified: 2020-02-28 06:12 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.78 KB, patch)
2020-02-27 10:43 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (5.13 KB, patch)
2020-02-27 14:05 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2020-02-28 05:41 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-02-27 10:40:36 PST 
commit queue should skip building and testing for rollout patches. This would match the behavior of old ews.
Comment 1 Aakash Jain 2020-02-27 10:43:01 PST 
Created attachment 391890 [details]
Patch
Comment 2 Aakash Jain 2020-02-27 10:56:39 PST 
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/926
Comment 3 Jonathan Bedard 2020-02-27 13:23:00 PST 
Comment on attachment 391890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391890&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1584
> +    incorrectLayoutLines = None

Is this supposed to be part of this patch?
Comment 4 Aakash Jain 2020-02-27 13:26:59 PST 
(In reply to Jonathan Bedard from comment #3)
> Is this supposed to be part of this patch?
Yes, without this there is an exception because self.incorrectLayoutLines in not defined in getResultSummary(). (e.g.: https://ews-build.webkit-uat.org/#/builders/26/builds/924)

  File "steps.py", line 1809, in getResultSummary
    if self.results != SUCCESS and self.incorrectLayoutLines:
  File "/usr/lib/python2.7/site-packages/buildbot/worker_transition.py", line 295, in __getattr__
    attr_name=name))
exceptions.AttributeError: 'RunWebKit1Tests' object has no attribute 'incorrectLayoutLines'
Comment 5 Jonathan Bedard 2020-02-27 13:50:35 PST 
(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > Is this supposed to be part of this patch?
> Yes, without this there is an exception because self.incorrectLayoutLines in
> not defined in getResultSummary(). (e.g.:
> https://ews-build.webkit-uat.org/#/builders/26/builds/924)
> 
>   File "steps.py", line 1809, in getResultSummary
>     if self.results != SUCCESS and self.incorrectLayoutLines:
>   File "/usr/lib/python2.7/site-packages/buildbot/worker_transition.py",
> line 295, in __getattr__
>     attr_name=name))
> exceptions.AttributeError: 'RunWebKit1Tests' object has no attribute
> 'incorrectLayoutLines'

Is it supposed to be a class variable? Or should it be an instance variable?
Comment 6 Aakash Jain 2020-02-27 14:05:49 PST 
Created attachment 391912 [details]
Patch
Comment 7 Aakash Jain 2020-02-27 14:06:50 PST 
(In reply to Jonathan Bedard from comment #5)
> Is it supposed to be a class variable? Or should it be an instance variable?
Updated patch uses instance variable.
Comment 8 Aakash Jain 2020-02-28 05:41:59 PST Comment hidden (obsolete)
Comment 9 Aakash Jain 2020-02-28 06:12:02 PST 
Committed r257636: <https://trac.webkit.org/changeset/257636>
Comment 10 Radar WebKit Bug Importer 2020-02-28 06:12:16 PST 
<rdar://problem/59886255>