Bug 208325 - Convert frame address in logging statements to pageID+frameID
Summary: Convert frame address in logging statements to pageID+frameID
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-27 09:57 PST by Keith Rollin
Modified: 2020-02-28 11:43 PST (History)
7 users (show)

See Also:

Attachments
Patch (36.94 KB, patch)
2020-02-27 10:08 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-02-27 09:57:20 PST 
Some old logging prints the address of the associated frame object. Annotating logging statements this way makes it difficult to match up that logging with other logging that uses pageID+frameID. Update the logging to consistently use the latter format.
Comment 1 Radar WebKit Bug Importer 2020-02-27 09:57:37 PST 
<rdar://problem/59850768>
Comment 2 Keith Rollin 2020-02-27 10:08:30 PST 
Created attachment 391887 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-28 11:43:39 PST 
Comment on attachment 391887 [details]
Patch

Clearing flags on attachment: 391887

Committed r257648: <https://trac.webkit.org/changeset/257648>
Comment 4 WebKit Commit Bot 2020-02-28 11:43:41 PST 
All reviewed patches have been landed.  Closing bug.