Check for navigation to app-bound domain during script evaluation

[Kate Cheney]

We should check for navigation to app-bound domain during script evaluation

[Kate Cheney]

<rdar://problem/57569321>

[Kate Cheney]

Created attachment 391894 [details]
Patch

[Kate Cheney]

Created attachment 391896 [details]
Patch

[Sam Weinig]

Comment on attachment 391896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391896&action=review

> Source/WebCore/ChangeLog:13
> +        * bindings/js/ScriptController.cpp:
> +        (WebCore::ScriptController::executeScriptInWorld):
> +        * loader/FrameLoaderClient.h:
> +        * page/Frame.cpp:
> +        (WebCore::Frame::injectUserScriptImmediately):

Please fill in the ChangeLog ensuring that you include why this change is being done, and what issue it is fixing.

[Kate Cheney]

Created attachment 392233 [details]
Patch

[Brent Fulgham]

Comment on attachment 392233 [details]
Patch

I think this looks correct based on what we discussed with Andy. Feel free to land this if the wk2 run completes successfully.

[Brent Fulgham]

Comment on attachment 392233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392233&action=review

> Source/WebKit/ChangeLog:56
> +        (WebKit::WebPage::runJavaScript):

So much state threading! :-D

[Kate Cheney]

Thanks for the review! Looks like all EWS are green. Style bot seems to always complain when adding a new function to FrameLoaderClient.h

[WebKit Commit Bot]

Comment on attachment 392233 [details]
Patch

Clearing flags on attachment: 392233

Committed r257780: <https://trac.webkit.org/changeset/257780>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59998428>