Bug 20830 – [GTK] Don't use deprecated pango API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jonathon Jongsma (jonner)]

the pango font backend currently uses some deprecated API which means that it will not compile with -DPANGO_DISABLE_DEPRECATED defined.

[Jonathon Jongsma (jonner)]

Created attachment 23397 [details]
don't use deprecated API

Notice that this requires a fairly new version of pango.  I suppose we could alternately use an #ifdef around the deprecated API to check for the pango version...

[Alp Toker]

Comment on attachment 23397 [details]
don't use deprecated API

Yep, 1.22 is just too recent to depend on. Change is fine if you wrap with PANGO_VERSION_CHECK() though (as we already do in another place in that file).

[Jonathon Jongsma (jonner)]

Created attachment 23399 [details]
Updated patch with PANGO_VERSION_CHECK guards

Wow, sorry about that.  I didn't even bother to check what the current version of pango is, and 1.22 isn't even released yet.  Oops.  So this patch should definitely be more appropriate.

[Alp Toker]

Comment on attachment 23399 [details]
Updated patch with PANGO_VERSION_CHECK guards

Our convention with version check macros is to put the success case first for consistency. Please update the patch or fix when landing, r=me otherwise

[Jonathon Jongsma (jonner)]

Created attachment 23415 [details]
Last patch with success case first

I also added your name as the reviewer to the changelog.  I don't have commit access, so I can't land the patch.

[Alp Toker]

Landed in r36614.