Bug 20830 - [GTK] Don't use deprecated pango API
Summary: [GTK] Don't use deprecated pango API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-13 09:50 PDT by Jonathon Jongsma (jonner)
Modified: 2008-09-18 04:50 PDT (History)
1 user (show)

See Also:

Attachments
don't use deprecated API (3.02 KB, patch)
2008-09-13 11:41 PDT, Jonathon Jongsma (jonner) 		alp: review-
Details | Formatted Diff | Diff
Updated patch with PANGO_VERSION_CHECK guards (2.82 KB, patch)
2008-09-13 20:22 PDT, Jonathon Jongsma (jonner) 		alp: review+
Details | Formatted Diff | Diff
Last patch with success case first (2.79 KB, patch)
2008-09-14 12:22 PDT, Jonathon Jongsma (jonner) 		alp: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathon Jongsma (jonner) 2008-09-13 09:50:01 PDT 
the pango font backend currently uses some deprecated API which means that it will not compile with -DPANGO_DISABLE_DEPRECATED defined.
Comment 1 Jonathon Jongsma (jonner) 2008-09-13 11:41:29 PDT 
Created attachment 23397 [details]
don't use deprecated API

Notice that this requires a fairly new version of pango.  I suppose we could alternately use an #ifdef around the deprecated API to check for the pango version...
Comment 2 Alp Toker 2008-09-13 17:48:19 PDT 
Comment on attachment 23397 [details]
don't use deprecated API

Yep, 1.22 is just too recent to depend on. Change is fine if you wrap with PANGO_VERSION_CHECK() though (as we already do in another place in that file).
Comment 3 Jonathon Jongsma (jonner) 2008-09-13 20:22:22 PDT 
Created attachment 23399 [details]
Updated patch with PANGO_VERSION_CHECK guards

Wow, sorry about that.  I didn't even bother to check what the current version of pango is, and 1.22 isn't even released yet.  Oops.  So this patch should definitely be more appropriate.
Comment 4 Alp Toker 2008-09-13 22:13:16 PDT 
Comment on attachment 23399 [details]
Updated patch with PANGO_VERSION_CHECK guards

Our convention with version check macros is to put the success case first for consistency. Please update the patch or fix when landing, r=me otherwise
Comment 5 Jonathon Jongsma (jonner) 2008-09-14 12:22:31 PDT 
Created attachment 23415 [details]
Last patch with success case first

I also added your name as the reviewer to the changelog.  I don't have commit access, so I can't land the patch.
Comment 6 Alp Toker 2008-09-18 04:50:43 PDT 
Landed in r36614.