Bug 208298 - Load async scripts with low priority
Summary: Load async scripts with low priority
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-27 05:47 PST by Antti Koivisto
Modified: 2020-02-27 08:03 PST (History)
12 users (show)

See Also:


Attachments
patch (13.17 KB, patch)
2020-02-27 06:32 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-02-27 05:47:50 PST
They are assumed to be non-critical. This matches other browsers.
Comment 1 Antti Koivisto 2020-02-27 06:32:39 PST
Created attachment 391854 [details]
patch
Comment 2 Anders Carlsson 2020-02-27 07:02:38 PST
Comment on attachment 391854 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391854&action=review

> Source/WebCore/dom/LoadableClassicScript.cpp:134
> +        return { };

I'd return std::nullopt here, but that's just me.
Comment 3 WebKit Commit Bot 2020-02-27 08:02:14 PST
Comment on attachment 391854 [details]
patch

Clearing flags on attachment: 391854

Committed r257566: <https://trac.webkit.org/changeset/257566>
Comment 4 WebKit Commit Bot 2020-02-27 08:02:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-02-27 08:03:17 PST
<rdar://problem/59847342>