Bug 208281 – [iPad Simulator] TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

The API test added with https://trac.webkit.org/changeset/257487/webkit is failing on iPad simulator bots with the following output:

    TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder
        
        /Volumes/Data/slave/ios-simulator-13-release/build/Tools/TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:125
        Expected equality of these values:
          "BODY"
          [webView stringByEvaluatingJavaScript:@"document.activeElement.tagName"]
            Which is: "DIV"
        
Example of failure:
https://build.webkit.org/builders/Apple%20iPadOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/2271

Test history:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder

[Radar WebKit Bug Importer]

<rdar://problem/59829265>

[Daniel Bates]

Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss keyboard or fake a keyboard dismissal. Can we skip the test on iPad?

[Ryan Haddad]

(In reply to Daniel Bates from comment #2)
> Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss
> keyboard or fake a keyboard dismissal. Can we skip the test on iPad?
Is there a platform check for iPad simulator that you could add to the test?
(I'm not sure if such a thing exists)

[Daniel Bates]

(In reply to Ryan Haddad from comment #3)
> (In reply to Daniel Bates from comment #2)
> > Oops. DismissFormAccesory is not enough for iPad. Need new SPI to dismiss
> > keyboard or fake a keyboard dismissal. Can we skip the test on iPad?
> Is there a platform check for iPad simulator that you could add to the test?
> (I'm not sure if such a thing exists)

So, not a way to skip a test, but there is a way to force an iPad to behave like an iPhone: IPhoneUserInterfaceSwizzler.

[Daniel Bates]

Created attachment 398335 [details]
Patch

[Daniel Bates]

Created attachment 398336 [details]
To Land

[Daniel Bates]

Comment on attachment 398336 [details]
To Land

Clearing flags on attachment: 398336

Committed r261068: <https://trac.webkit.org/changeset/261068>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

Committed build fix <https://trac.webkit.org/changeset/261069>