media/modern-media-controls/pip-support/pip-support-click.html Description: This test is flaky timing out on Mac wk2. It appears to have a possible regression point of r257394. History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fpip-support%2Fpip-support-click.html&flavor=wk2&limit=50000 Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-actual.txt @@ -1,11 +1,6 @@ -Testing the PiPSupport behavior when clicking the PiP button. +CONSOLE MESSAGE: Unhandled Promise Rejection: InvalidStateError: The video element does not have a video track or it has not detected a video track yet. +#PID UNRESPONSIVE - WebKitTestRunner (pid 78234) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS mediaController.controls.pipButton.element.getBoundingClientRect().width became different from 0 -PASS media.webkitPresentationMode is "picture-in-picture" -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF
<rdar://problem/59825227>
I have marked this test as timing out while this issue is investigated. https://trac.webkit.org/changeset/257525/webkit
This timeout issue appears to have started on r257394. I can reproduce the timeout issue on r257515 and r257394, but I cannot on r257391. This is the command that I used: run-webkit-tests --force -f --exit-after-n-failures 3 --iterations 1000 media/modern-media-controls/pip-support/pip-support-click.html r257515: [22/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (text diff) [51/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) [52/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) Exiting early after 3 failures. 49 tests run. 46 tests ran as expected, 3 didn't (951 didn't run): r257394: [76/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) [77/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) [90/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (test timed out, text diff) Exiting early after 3 failures. 87 tests run. 84 tests ran as expected, 3 didn't (913 didn't run): r257391: [8/1000] media/modern-media-controls/pip-support/pip-support-click.html failed unexpectedly (text diff) Retrying 1 unexpected failure .. Running 1 WebKitTestRunner. 999 tests ran as expected, 1 didn't:
*** Bug 208333 has been marked as a duplicate of this bug. ***
Created attachment 391901 [details] Patch
This test sometimes fails because it presses the PIP control before the video starts playing. Jer suggested that I work around this by only playing the video after the event handler that presses the PIP control is set up. That's what I've done in this patch.
Created attachment 391910 [details] Patch for landing
Comment on attachment 391910 [details] Patch for landing Rejecting attachment 391910 [details] from commit-queue. nham@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Committed r257585: <https://trac.webkit.org/changeset/257585>