Bug 208263 - AXIsolatedObject support for table cells.
Summary: AXIsolatedObject support for table cells.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-26 14:23 PST by Andres Gonzalez
Modified: 2020-02-26 18:32 PST (History)
10 users (show)

See Also:


Attachments
Patch (33.34 KB, patch)
2020-02-26 14:31 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (33.33 KB, patch)
2020-02-26 16:09 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (36.51 KB, patch)
2020-02-26 17:02 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-02-26 14:23:16 PST
AXIsolatedObject support for table cells.
Comment 1 Andres Gonzalez 2020-02-26 14:31:42 PST
Created attachment 391783 [details]
Patch
Comment 2 chris fleizach 2020-02-26 15:00:57 PST
Comment on attachment 391783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391783&action=review

> Source/WebCore/accessibility/AccessibilityARIAGridCell.h:41
> +    // Returnss the start location and row span of the cell.

spelling/: Returnss

> Source/WebCore/accessibility/AccessibilityObject.h:176
> +    // Returnss the start location and row span of the cell.

spelling Returnss

> Source/WebCore/accessibility/AccessibilityObjectInterface.h:557
> +    // Returnss the start location and row span of the cell.

spelling

> Source/WebCore/accessibility/AccessibilityTableCell.h:48
> +    // Returnss the start location and row span of the cell.

spelling
Comment 3 chris fleizach 2020-02-26 15:09:36 PST
build failures look unrelated
Comment 4 chris fleizach 2020-02-26 15:09:49 PST
Comment on attachment 391783 [details]
Patch

approved pending spelling changes
Comment 5 Andres Gonzalez 2020-02-26 16:09:22 PST
Created attachment 391798 [details]
Patch
Comment 6 Andres Gonzalez 2020-02-26 17:02:29 PST
Created attachment 391812 [details]
Patch
Comment 7 WebKit Commit Bot 2020-02-26 18:31:40 PST
Comment on attachment 391812 [details]
Patch

Clearing flags on attachment: 391812

Committed r257548: <https://trac.webkit.org/changeset/257548>
Comment 8 WebKit Commit Bot 2020-02-26 18:31:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-02-26 18:32:20 PST
<rdar://problem/59831471>