Bug 208251 – REGRESSION: (257410) [ macOS ] inspector/network/client-blocked-load.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Jacob Uphoff]

inspector/network/client-blocked-load.html is failing after commit r257410 on all of Mac OS

[Radar WebKit Bug Importer]

<rdar://problem/59812765>

[Jacob Uphoff]

History: https://results.webkit.org/?suite=layout-tests&test=inspector%2Fnetwork%2Fclient-blocked-load.html

[Jacob Uphoff]

Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/inspector/network/client-blocked-load-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/inspector/network/client-blocked-load-actual.txt
@@ -4,6 +4,8 @@
 == Running test suite: ClientBlockedResourceLoad
 -- Running test case: TriggerBlockedResourceLoad
 PASS: Resource should be created.
-PASS: Request url should be rewritten to the null string.
+FAIL: Request url should be rewritten to the null string.
+    Expected: truthy
+    Actual: false
 PASS: Resource load should fail.

[Devin Rousso]

Created attachment 391761 [details]
Patch

[Timothy Hatcher]

Comment on attachment 391761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391761&action=review

> Source/WebInspectorUI/UserInterface/Models/SourceCode.js:32
> +        this._url = url;

Could you use ?? Instead?

[Devin Rousso]

Comment on attachment 391761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391761&action=review

>> Source/WebInspectorUI/UserInterface/Models/SourceCode.js:32
>> +        this._url = url;
> 
> Could you use ?? Instead?

I could've, and initially I did just that :P

For the reason listed in the ChangeLog, I'd prefer to avoid introducing a potential other bug by changing functionality.  I think it's safer to just leave it as it was.

[WebKit Commit Bot]

Comment on attachment 391761 [details]
Patch

Clearing flags on attachment: 391761

Committed r257504: <https://trac.webkit.org/changeset/257504>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.