RESOLVED FIXED208245
[ iOS wk2 Release ] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html is flaky failing. 
https://bugs.webkit.org/show_bug.cgi?id=208245
Summary [ iOS wk2 Release ] fast/text-autosizing/ios/idempotentmode/viewport-change-r...
Attachments
viewport-change-relayout-diff.png (15.25 KB, image/png)
2020-02-26 09:04 PST, Jason Lawrence 		no flags
Details
Patch (4.88 KB, patch)
2020-02-28 11:44 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (4.88 KB, patch)
2020-02-28 11:44 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-26 09:05:22 PST
<rdar://problem/59807462>
Jason Lawrence
Comment 2 2020-02-26 09:14:13 PST
I have marked this test as failing while the issue is investigated. https://trac.webkit.org/changeset/257476/webkit
Jason Lawrence
Comment 3 2020-02-26 09:22:31 PST
I am able to reproduce this issue with r257468 by running the command below. run-webkit-tests fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html --iterations 3000 --exit-after-n-failures 5 -f --force --ios-simulator [4/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) [4/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) [6/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) [7/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) [8/3000] fast/text-autosizing/ios/idempotentmode/viewport-change-relayout.html failed unexpectedly (reference mismatch) Exiting early after 5 failures. 6 tests run. 1 test ran as expected, 5 didn't (2994 didn't run):
Ryan Haddad
Comment 4 2020-02-26 10:25:44 PST
This is a brand new test added with https://bugs.webkit.org/show_bug.cgi?id=208084
Ryan Haddad
Comment 5 2020-02-26 11:02:29 PST
We rolled out the change that introduced this test, so we should remove this test expectation entry and close the bug.
Jason Lawrence
Comment 6 2020-02-26 14:32:38 PST
I have removed the test expectations. https://trac.webkit.org/changeset/257516/webkit
Ryan Haddad
Comment 7 2020-02-27 12:03:54 PST
This test is failing again after it was re-landed in https://trac.webkit.org/changeset/257550
Radar WebKit Bug Importer
Comment 8 2020-02-27 12:05:41 PST
<rdar://problem/59856625>
Ryan Haddad
Comment 9 2020-02-27 13:43:46 PST
Marked test as flaky again in https://trac.webkit.org/changeset/257582/webkit
Myles C. Maxfield
Comment 10 2020-02-28 11:05:19 PST
According to that screenshot, the test is still passing, it is just being rendered with a viewport size that is unexpected. The solution is probably to turn this into a text test.
Myles C. Maxfield
Comment 11 2020-02-28 11:22:44 PST
Alright, I have a fix, testing it now.
Myles C. Maxfield
Comment 12 2020-02-28 11:44:14 PST
Created attachment 392001 [details] Patch
Myles C. Maxfield
Comment 13 2020-02-28 11:44:46 PST
Created attachment 392002 [details] Patch
WebKit Commit Bot
Comment 14 2020-02-28 12:11:31 PST
Comment on attachment 392002 [details] Patch Clearing flags on attachment: 392002 Committed r257651: <https://trac.webkit.org/changeset/257651>
WebKit Commit Bot
Comment 15 2020-02-28 12:11:33 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 16 2020-02-28 16:48:32 PST
Removed flaky expectation in https://trac.webkit.org/changeset/257669/webkit
Note You need to log in before you can comment on or make changes to this bug.