Bug 208238 - Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
Summary: Use WebPageProxy preferences for capture instead of WebProcessPool configurat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-26 05:20 PST by youenn fablet
Modified: 2020-03-16 17:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch (15.15 KB, patch)
2020-02-26 05:28 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-26 05:20:43 PST 
Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
Comment 1 youenn fablet 2020-02-26 05:28:56 PST 
Created attachment 391741 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-02-26 05:40:38 PST 
<rdar://problem/59803140>
Comment 3 WebKit Commit Bot 2020-02-26 07:57:25 PST 
Comment on attachment 391741 [details]
Patch

Clearing flags on attachment: 391741

Committed r257472: <https://trac.webkit.org/changeset/257472>
Comment 4 WebKit Commit Bot 2020-02-26 07:57:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Z 2020-03-16 15:21:31 PDT 
Not able to run Safari on Catalina (10.15.3)

$ svn info
Path: .
Working Copy Root Path: /Users/user/webkit
URL: https://svn.webkit.org/repository/webkit/trunk
Relative URL: ^/trunk
Repository Root: https://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 258497
Node Kind: directory
Schedule: normal
Last Changed Author: commit-queue@webkit.org
Last Changed Rev: 258497
Last Changed Date: 2020-03-16 10:27:05 -0500 (Mon, 16 Mar 2020)

Configured as

$ Tools/Scripts/set-webkit-configuration --asan --release

Built as

$ Tools/Scripts/build-webkit

Run

$ Tools/Scripts/run-safari 
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/user/webkit/WebKitBuild/Release.
dyld: Symbol not found: _WKContextConfigurationSetShouldCaptureAudioInUIProcess
  Referenced from: /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
  Expected in: /Users/user/webkit/WebKitBuild/Release/WebKit.framework/Versions/A/WebKit
 in /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari