Bug 208213 - Stub Repository needs to call the scm constructor
Summary: Stub Repository needs to call the scm constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Lewis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-25 12:46 PST by Matt Lewis
Modified: 2020-02-25 15:06 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2020-02-25 13:52 PST, Matt Lewis 		no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2020-02-25 14:18 PST, Matt Lewis 		jbedard: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2020-02-25 12:46:30 PST 
stub_repository.py needs to call the scm constructor.
Comment 1 Radar WebKit Bug Importer 2020-02-25 13:41:59 PST 
<rdar://problem/59778312>
Comment 2 Matt Lewis 2020-02-25 13:52:12 PST 
Created attachment 391681 [details]
Patch

This is actually the correct fix I think as when adding stub repository support initially we left out the scm initilization due to trying to override the fact that we don't actually have a SCM. Initiallizing it could have further complications with the filesystems that getr passed around.
Comment 3 Jonathan Bedard 2020-02-25 13:54:47 PST 
Comment on attachment 391681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391681&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/stub_repository.py:42
> +        self.checkout_root = self.find_checkout_root(cwd)

Can we call out in a comment why we aren't calling the parent's constructor? That's the sort of mistake I would expect a future contributor to make.
Comment 4 Matt Lewis 2020-02-25 14:18:16 PST 
Created attachment 391686 [details]
Patch

Added a comment to signify why we aren't calling the parent.
Comment 5 Matt Lewis 2020-02-25 15:06:24 PST 
Committed r257378: <https://trac.webkit.org/changeset/257378>