Add SPI to query WKFrameInfos in a WKWebView
Created attachment 391675 [details] Patch
Created attachment 391695 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Created attachment 391720 [details] Patch
Comment on attachment 391720 [details] Patch Rejecting attachment 391720 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 391720, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: ceeded at 1811 (offset 5 lines). Hunk #7 succeeded at 1836 (offset 5 lines). patching file Source/WebKit/UIProcess/WebPageProxy.messages.in patching file Source/WebKit/UIProcess/API/APIFrameInfo.cpp patching file Source/WebKit/UIProcess/API/APIFrameInfo.h patching file Source/WebKit/UIProcess/API/APINavigationClient.h patching file Source/WebKit/UIProcess/API/APIUIClient.h Hunk #5 succeeded at 197 with fuzz 2. patching file Source/WebKit/UIProcess/API/C/WKFrame.cpp patching file Source/WebKit/UIProcess/API/C/WKFrame.h patching file Source/WebKit/UIProcess/API/C/WKFrameInfoRef.cpp patching file Source/WebKit/UIProcess/API/C/WKFrameInfoRef.h patching file Source/WebKit/UIProcess/API/C/WKPage.cpp patching file Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm patching file Source/WebKit/UIProcess/API/Cocoa/WKFrameInfoPrivate.h patching file Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm Hunk #1 succeeded at 1582 (offset 14 lines). patching file Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h Hunk #2 succeeded at 172 (offset 1 line). patching file Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp patching file Source/WebKit/UIProcess/Cocoa/NavigationState.h patching file Source/WebKit/UIProcess/Cocoa/NavigationState.mm patching file Source/WebKit/UIProcess/Cocoa/UIDelegate.h Hunk #2 FAILED at 121. Hunk #3 succeeded at 155 (offset -1 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/Cocoa/UIDelegate.h.rej patching file Source/WebKit/UIProcess/Cocoa/UIDelegate.mm Hunk #1 succeeded at 272 (offset -3 lines). Hunk #2 succeeded at 286 (offset -3 lines). Hunk #3 succeeded at 294 (offset -3 lines). Hunk #4 succeeded at 308 (offset -3 lines). Hunk #5 succeeded at 316 (offset -3 lines). Hunk #6 succeeded at 330 (offset -3 lines). Hunk #7 succeeded at 362 (offset -3 lines). Hunk #8 succeeded at 372 (offset -3 lines). Hunk #9 succeeded at 397 (offset -3 lines). Hunk #10 succeeded at 411 (offset -3 lines). Hunk #11 succeeded at 813 (offset -3 lines). Hunk #12 succeeded at 822 (offset -3 lines). Hunk #13 succeeded at 848 (offset -15 lines). Hunk #14 succeeded at 860 (offset -15 lines). Hunk #15 succeeded at 1281 (offset -15 lines). Hunk #16 succeeded at 1295 (offset -15 lines). patching file Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm patching file Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm patching file Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp patching file Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationRequestData.h patching file Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp patching file Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h patching file Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in patching file Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp patching file Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.h patching file Source/WebKit/UIProcess/ios/PageClientImplIOS.h patching file Source/WebKit/UIProcess/ios/PageClientImplIOS.mm patching file Source/WebKit/UIProcess/ios/WKGeolocationProviderIOS.h patching file Source/WebKit/UIProcess/ios/WKGeolocationProviderIOS.mm patching file Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp patching file Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp patching file Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp Hunk #6 succeeded at 1336 (offset -13 lines). patching file Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Hunk #2 FAILED at 834. Hunk #3 succeeded at 876 (offset 5 lines). Hunk #4 succeeded at 937 (offset 5 lines). Hunk #5 succeeded at 1005 (offset 5 lines). Hunk #6 succeeded at 1015 (offset 5 lines). 1 out of 6 hunks FAILED -- saving rejects to file Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp.rej patching file Source/WebKit/WebProcess/WebPage/WebFrame.cpp patching file Source/WebKit/WebProcess/WebPage/WebFrame.h patching file Source/WebKit/WebProcess/WebPage/WebPage.cpp patching file Source/WebKit/WebProcess/WebPage/WebPage.h patching file Source/WebKit/WebProcess/WebPage/WebPage.messages.in patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Hunk #2 succeeded at 1776 (offset 1 line). Hunk #3 succeeded at 3755 (offset 3 lines). Hunk #4 succeeded at 4811 (offset 4 lines). patching file Tools/TestWebKitAPI/Tests/WebKit/FrameHandle.cpp rm 'Tools/TestWebKitAPI/Tests/WebKit/FrameHandle.cpp' patching file Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm patching file Tools/WebKitTestRunner/TestController.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brady Eidson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13329492
http://trac.webkit.org/r257530
<rdar://problem/59826856>
Reverted r257530 for reason: This commit seems to have broke the build internally for watchOS Committed r257567: <https://trac.webkit.org/changeset/257567>
Comment on attachment 391720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391720&action=review > Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp:40 > + SecurityOriginData originData = frameInfo.securityOrigin; This file needs to include FrameInfoData.h
http://trac.webkit.org/r257571