Bug 208210 - [WinCairo] Fix build after revisions 257357 and 257354
Summary: [WinCairo] Fix build after revisions 257357 and 257354
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-25 10:47 PST by Don Olmstead
Modified: 2020-02-25 11:36 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2020-02-25 10:49 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-02-25 10:47:49 PST 
Couple compilation issues cropped up due to our EWS being in a bad state.
Comment 1 Don Olmstead 2020-02-25 10:49:32 PST 
Created attachment 391669 [details]
Patch
Comment 2 Basuke Suzuki 2020-02-25 10:54:03 PST 
Comment on attachment 391669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391669&action=review

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:507
> +    auto expires = cookie.expires.valueOr(0.0);

Looks good to me
Comment 3 WebKit Commit Bot 2020-02-25 11:35:20 PST 
Comment on attachment 391669 [details]
Patch

Clearing flags on attachment: 391669

Committed r257368: <https://trac.webkit.org/changeset/257368>
Comment 4 WebKit Commit Bot 2020-02-25 11:35:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-02-25 11:36:15 PST 
<rdar://problem/59773138>