Bug 208206 – Tests should each use a unique ResourceLoadStatistics file path for its database store

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

This is causing issues with tests trying to delete file paths for databases which are still in use

[Kate Cheney]

<rdar://problem/59690272>

[Kate Cheney]

Created attachment 391672 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 391672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391672&action=review

> Source/WebKit/ChangeLog:13
> +        WebKitTestRunner. This was causing crashes and concurrency issues in tests 
> +        when multiple database stores at the same path are accessed
> +        simultaneously.

I'll leave it to someone who knows this code to review the patch, but this is exciting!

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:180
> -        // FIXME(193297): This should be revised after the UIProcess version goes away.
> -        m_statisticsStore->didCreateNetworkProcess();
> -    });
> +            // FIXME(193297): This should be revised after the UIProcess version goes away.

Bug 193297 is marked as fixed, it would be helpful to update this comment with what needs to be done. Not required for this patch, but you touched the line.

[Alexey Proskuryakov]

(also, API tests failed)

[Kate Cheney]

Created attachment 391708 [details]
Patch

[Kate Cheney]

(In reply to Alexey Proskuryakov from comment #4)
> (also, API tests failed)

This patch should fix it.

[Kate Cheney]

(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 391672 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391672&action=review
> 
> > Source/WebKit/ChangeLog:13
> > +        WebKitTestRunner. This was causing crashes and concurrency issues in tests 
> > +        when multiple database stores at the same path are accessed
> > +        simultaneously.
> 
> I'll leave it to someone who knows this code to review the patch, but this
> is exciting!

I know! I think this will solve many of the DB flaky test issues.

[WebKit Commit Bot]

Comment on attachment 391708 [details]
Patch

Clearing flags on attachment: 391708

Committed r257519: <https://trac.webkit.org/changeset/257519>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59822319>

[Kate Cheney]

*** Bug 207938 has been marked as a duplicate of this bug. ***