Bug 20820 – op_stricteq is slow

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Cameron Zwarich (cpst)]

op_stricteq is 1.7% of the Shark profile of the Earley-Boyer benchmark. We should determine why this is the case and fix it.

[Maciej Stachowiak]

Created attachment 23619 [details]
more speedups for the CTI case

[Darin Adler]

Comment on attachment 23619 [details]
more speedups for the CTI case

+        (JSC::Machine::cti_op_stricteq): Check for pointer equality first; use inline version
+        of strictEqualSlowCase; remove unneeded exception check.

I don't see any "check for pointer equality first" change.

-            r[dst] = jsBoolean(reinterpret_cast<intptr_t>(src1) == reinterpret_cast<intptr_t>(src2));
+            r[dst]= jsBoolean(reinterpret_cast<intptr_t>(src1) == reinterpret_cast<intptr_t>(src2));

Should change this back. No reason to delete the space before that "=".

-    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 != JSImmediate::from(0)) & (src2 != JSImmediate::from(0)))
+    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 != JSImmediate::zeroImmediate()) & (src2 != JSImmediate::zeroImmediate()))

JSImmediate::from(0) doesn't get constant folded?

r=me

[Maciej Stachowiak]

(In reply to comment #2)
> (From update of attachment 23619 [details] [edit])
> +        (JSC::Machine::cti_op_stricteq): Check for pointer equality first; use
> inline version
> +        of strictEqualSlowCase; remove unneeded exception check.
> 
> I don't see any "check for pointer equality first" change.

Oh right, I had to back that out after writing the ChangeLog because it was wrong for NaN. I'll fix ChangeLog too.

> 
> -            r[dst] = jsBoolean(reinterpret_cast<intptr_t>(src1) ==
> reinterpret_cast<intptr_t>(src2));
> +            r[dst]= jsBoolean(reinterpret_cast<intptr_t>(src1) ==
> reinterpret_cast<intptr_t>(src2));
> 
> Should change this back. No reason to delete the space before that "=".
>

I fixed that.
 
> -    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 !=
> JSImmediate::from(0)) & (src2 != JSImmediate::from(0)))
> +    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 !=
> JSImmediate::zeroImmediate()) & (src2 != JSImmediate::zeroImmediate()))
> 
> JSImmediate::from(0) doesn't get constant folded?
> 

I think both get constant folded, but I figued it was better style to use zeroImmediate().

[Maciej Stachowiak]

Created attachment 23624 [details]
inline JIT the fast paths of the strict equal operator

[Maciej Stachowiak]

Comment on attachment 23619 [details]
more speedups for the CTI case

unflagging since this is landed

[Darin Adler]

http://trac.webkit.org/changeset/36738