Bug 208167 – ASSERTION FAILED: Completion handler should always be called on inspector/dom-debugger/attribute-modified-style.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Jason Lawrence]

Created attachment 391597 [details]
crash log

inspector/dom-debugger/attribute-modified-style.html

Description:
This test is flaky failing on Mac wk2 Debug. The first crash that I see is on r256912.

History:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Fdom-debugger%2Fattribute-modified-style.html&platform=mac&limit=50000&flavor=wk2&style=debug

Crash log attached.

[Jason Lawrence]

I have marked this test as crashing while this issue is investigated.
https://trac.webkit.org/changeset/257282/webkit

[Radar WebKit Bug Importer]

<rdar://problem/59747016>

[Alexey Proskuryakov]

stderr:
ASSERTION FAILED: Completion handler should always be called
!m_function
/Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/usr/local/include/wtf/CompletionHandler.h(53) : WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData> &&)>::~CompletionHandler()
1   0x129b6d9f9 WTFCrash
2   0x103321ee3 WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)>::~CompletionHandler()
3   0x103320ba5 WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)>::~CompletionHandler()
4   0x103914e59 WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> >::~KeyValuePair()
5   0x103914da5 WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> >::~KeyValuePair()
6   0x103914d11 WTF::HashTable<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> > >, WTF::ObjectIdentifierHash<WebCore::ServiceWorkerJobIdentifierType>, WTF::HashMap<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)>, WTF::ObjectIdentifierHash<WebCore::ServiceWorkerJobIdentifierType>, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType> >, WTF::HashTraits<WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> > >::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType> > >::deallocateTable(WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> >*)

[Alexey Proskuryakov]

This shows up as a recent regression (a week ago) on this test, however it's clearly a culprit of some SW test. So the crash may have just moved.

[Alexey Proskuryakov]

http://trac.webkit.org/r256900 doesn't look entirely unrelated though...

[Jason Lawrence]

I was able to reproduce this issue with r257181 by running the command below.
run-webkit—tests inspector/dom-debugger/attribute-modified-style.html --iterations 4000 --exit-after-n-failures 5 --force --platform mac-mojave --debug -g

Output:
[1052/4000] inspector/dom-debugger/attribute-modified-style.html failed unexpectedly (text diff)
Interrupted, exiting ...
1831 tests ran as expected, 1 didn't (2168 didn't run):

[Jason Lawrence]

Correction. I was not able to reproduce the issue, I got a failure not a crash. Please disregard my comment on 2020-02-25 07:18:13 PST.

[Alexey Proskuryakov]

Youenn fixed this via bug 208208. Still need to unmark the test. Jason or Youenn, could you please take care of that?

[youenn fablet]

Created attachment 392122 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 392122 [details]
Patch

Clearing flags on attachment: 392122

Committed r257706: <https://trac.webkit.org/changeset/257706>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.