WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
208157
Prevent text selection on logo and header navigation
https://bugs.webkit.org/show_bug.cgi?id=208157
Summary
Prevent text selection on logo and header navigation
Jon Davis
Reported
2020-02-24 14:33:41 PST
Prevent user selection for the WebKit website logo and header navigation elements.
Attachments
Patch
(1.43 KB, patch)
2020-02-24 14:38 PST
,
Jon Davis
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jon Davis
Comment 1
2020-02-24 14:38:22 PST
Created
attachment 391580
[details]
Patch
Devin Rousso
Comment 2
2020-02-25 14:04:17 PST
Comment on
attachment 391580
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=391580&action=review
r=me
> Websites/webkit.org/wp-content/themes/webkit/style.css:2103 > header nav {
Why not put this on `header`? Right now (with this patch), the "WebKit" next to the logo is still selectable. Do we want that?
Devin Rousso
Comment 3
2020-02-26 14:05:08 PST
Comment on
attachment 391580
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=391580&action=review
>> Websites/webkit.org/wp-content/themes/webkit/style.css:2103 >> header nav { > > Why not put this on `header`? > > Right now (with this patch), the "WebKit" next to the logo is still selectable. Do we want that?
I just spoke with @Jon offline, and I misread this patch. All good :)
WebKit Commit Bot
Comment 4
2020-02-26 14:52:48 PST
Comment on
attachment 391580
[details]
Patch Clearing flags on attachment: 391580 Committed
r257520
: <
https://trac.webkit.org/changeset/257520
>
WebKit Commit Bot
Comment 5
2020-02-26 14:52:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2020-02-26 14:53:15 PST
<
rdar://problem/59822703
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug