WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
208154
ImageBuffer should not use ImageData since this is a layering violation
https://bugs.webkit.org/show_bug.cgi?id=208154
Summary
ImageBuffer should not use ImageData since this is a layering violation
Said Abou-Hallawa
Reported
2020-02-24 13:25:02 PST
ImageBuffer::getImageData() and ImageBuffer::puttImageData() deal with ImageData. Since ImageBuffer is in platform/graphics and ImageData is in html, this is considered a layering violation. The fix could be the following: 1. Move ImageData to platform/graphics except the DOM ImageData creation methods. 2. Add DOMImageData to html and make it inherit from ImageData. 3. Add the DOM ImageData creation methods to DOMImageData. 4. Rename ImageData.idl to DOMImageData.idl but make InterfaceName=ImageData. 5. Change all the DOM related reference to ImageData to be DOMImageData.
Attachments
Patch
(72.46 KB, patch)
2020-02-25 18:32 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(70.84 KB, patch)
2020-02-25 18:34 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1
2020-02-25 18:32:08 PST
Created
attachment 391712
[details]
Patch
Said Abou-Hallawa
Comment 2
2020-02-25 18:34:27 PST
Created
attachment 391713
[details]
Patch
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug