Bug 208151 - LLInt should fast path for jtrue/false on Symbols and Objects
Summary: LLInt should fast path for jtrue/false on Symbols and Objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-24 12:28 PST by Keith Miller
Modified: 2020-02-24 15:52 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2020-02-24 12:32 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2020-02-24 14:23 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-02-24 12:28:07 PST 
LLInt should fast path for jtrue/false on Symbols and Objects
Comment 1 Keith Miller 2020-02-24 12:32:55 PST 
Created attachment 391566 [details]
Patch
Comment 2 Yusuke Suzuki 2020-02-24 12:52:17 PST 
Comment on attachment 391566 [details]
Patch

Does this handle masquerade-as-undefined objects? These objects need to be evaluated as false in certain context IIRC.
Comment 3 Keith Miller 2020-02-24 13:58:52 PST 
(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 391566 [details]
> Patch
> 
> Does this handle masquerade-as-undefined objects? These objects need to be
> evaluated as false in certain context IIRC.

Yeah, probably, I should have run-non-test262 tests before uploading...
Comment 4 Keith Miller 2020-02-24 14:23:45 PST 
Created attachment 391576 [details]
Patch
Comment 5 Yusuke Suzuki 2020-02-24 15:19:54 PST 
Comment on attachment 391576 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2020-02-24 15:51:33 PST 
Comment on attachment 391576 [details]
Patch

Clearing flags on attachment: 391576

Committed r257270: <https://trac.webkit.org/changeset/257270>
Comment 7 WebKit Commit Bot 2020-02-24 15:51:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-24 15:52:22 PST 
<rdar://problem/59744579>