Bug 208135 - Remove throttling code from RenderLayerCompositor
Summary: Remove throttling code from RenderLayerCompositor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-24 07:43 PST by Antti Koivisto
Modified: 2020-02-26 05:38 PST (History)
18 users (show)

See Also:


Attachments
patch (26.80 KB, patch)
2020-02-24 07:47 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (26.91 KB, patch)
2020-02-24 07:56 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (26.91 KB, patch)
2020-02-24 08:08 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (31.10 KB, patch)
2020-02-25 00:26 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (31.10 KB, patch)
2020-02-25 01:04 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (31.76 KB, patch)
2020-02-25 01:15 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
revert back to notifyFlushRequired (13.57 KB, patch)
2020-02-26 03:15 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
revert back to notifyFlushRequired (13.57 KB, patch)
2020-02-26 03:37 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
revert back to notifyFlushRequired (14.18 KB, patch)
2020-02-26 04:32 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
revert back to notifyFlushRequired (15.86 KB, patch)
2020-02-26 04:34 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-02-24 07:43:54 PST
It is only used on WK1, adds lots of complexity and is not very effective.
Comment 1 Antti Koivisto 2020-02-24 07:47:42 PST
Created attachment 391538 [details]
patch
Comment 2 Antti Koivisto 2020-02-24 07:56:59 PST
Created attachment 391541 [details]
patch
Comment 3 Antti Koivisto 2020-02-24 08:08:16 PST
Created attachment 391543 [details]
patch
Comment 4 Simon Fraser (smfr) 2020-02-24 10:59:19 PST
Nice.
Comment 5 Antti Koivisto 2020-02-25 00:26:10 PST
Created attachment 391631 [details]
patch
Comment 6 Antti Koivisto 2020-02-25 01:04:48 PST
Created attachment 391633 [details]
patch
Comment 7 Antti Koivisto 2020-02-25 01:15:44 PST
Created attachment 391635 [details]
patch
Comment 8 WebKit Commit Bot 2020-02-25 08:36:05 PST
Comment on attachment 391635 [details]
patch

Clearing flags on attachment: 391635

Committed r257357: <https://trac.webkit.org/changeset/257357>
Comment 9 WebKit Commit Bot 2020-02-25 08:36:08 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-02-25 08:37:16 PST
<rdar://problem/59765410>
Comment 11 Simon Fraser (smfr) 2020-02-25 11:04:23 PST
Comment on attachment 391635 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391635&action=review

> Source/WebCore/platform/graphics/GraphicsLayerClient.h:101
> -    virtual void notifyFlushRequired(const GraphicsLayer*) { }
> +    virtual void notifyRenderingUpdateRequired(const GraphicsLayer*) { }

I would not have renamed this one, because it should have the same name as GraphicsLayer::flushCompositingState() which you did not rename.

Down here we're flushing, not doing rendering updates.
Comment 12 Antti Koivisto 2020-02-25 11:53:11 PST
> I would not have renamed this one, because it should have the same name as
> GraphicsLayer::flushCompositingState() which you did not rename.
> 
> Down here we're flushing, not doing rendering updates.

Ok, I'll rename it back.
Comment 13 Antti Koivisto 2020-02-26 03:15:07 PST
Created attachment 391732 [details]
revert back to notifyFlushRequired
Comment 14 Antti Koivisto 2020-02-26 03:36:52 PST
add a followup
Comment 15 Antti Koivisto 2020-02-26 03:37:38 PST
Created attachment 391734 [details]
revert back to notifyFlushRequired
Comment 16 Antti Koivisto 2020-02-26 04:32:37 PST
Created attachment 391736 [details]
revert back to notifyFlushRequired
Comment 17 Antti Koivisto 2020-02-26 04:34:41 PST
Created attachment 391737 [details]
revert back to notifyFlushRequired
Comment 18 WebKit Commit Bot 2020-02-26 05:38:04 PST
Comment on attachment 391737 [details]
revert back to notifyFlushRequired

Clearing flags on attachment: 391737

Committed r257465: <https://trac.webkit.org/changeset/257465>
Comment 19 WebKit Commit Bot 2020-02-26 05:38:06 PST
All reviewed patches have been landed.  Closing bug.