Bug 208112 - [LFC][IFC][Floats] Fix float boxes embedded to unbreakable inline runs.
Summary: [LFC][IFC][Floats] Fix float boxes embedded to unbreakable inline runs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-23 14:03 PST by zalan
Modified: 2020-02-24 23:39 PST (History)
8 users (show)

See Also:

Attachments
Patch (25.34 KB, patch)
2020-02-23 14:16 PST, zalan 		no flags Details | Formatted Diff | Diff
Unbreakable content with floats (534.87 KB, image/png)
2020-02-23 14:23 PST, zalan 		no flags Details
Mix of breakable and unbreakable content (543.15 KB, image/png)
2020-02-23 14:24 PST, zalan 		no flags Details
Floats with unbreakable content (584.80 KB, image/png)
2020-02-23 17:25 PST, zalan 		no flags Details
Floats with breakable and unbreakable content (584.80 KB, image/png)
2020-02-23 17:26 PST, zalan 		no flags Details
test case ^^ (588 bytes, text/html)
2020-02-23 17:27 PST, zalan 		no flags Details
Patch (25.08 KB, patch)
2020-02-23 17:35 PST, zalan 		no flags Details | Formatted Diff | Diff
Floats with breakable and unbreakable content (559.86 KB, image/png)
2020-02-23 17:38 PST, zalan 		no flags Details
Patch (25.10 KB, patch)
2020-02-24 14:42 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-23 14:03:30 PST 
text_<float box></float box>_content -> potentially intrusive float embedded to [text_][_content]
Comment 1 Radar WebKit Bug Importer 2020-02-23 14:03:48 PST 
<rdar://problem/59709701>
Comment 2 zalan 2020-02-23 14:16:04 PST 
Created attachment 391499 [details]
Patch
Comment 3 zalan 2020-02-23 14:23:31 PST 
Created attachment 391500 [details]
Unbreakable content with floats

This is a comparison of how floats embedded to unbreakable content is rendered by browsers.
Comment 4 zalan 2020-02-23 14:24:31 PST 
Created attachment 391501 [details]
Mix of breakable and unbreakable content
Comment 5 zalan 2020-02-23 17:25:44 PST 
Created attachment 391504 [details]
Floats with unbreakable content
Comment 6 zalan 2020-02-23 17:26:06 PST 
Created attachment 391505 [details]
Floats with breakable and unbreakable content
Comment 7 zalan 2020-02-23 17:27:03 PST 
Created attachment 391506 [details]
test case ^^
Comment 8 zalan 2020-02-23 17:35:28 PST 
Created attachment 391507 [details]
Patch
Comment 9 zalan 2020-02-23 17:38:58 PST 
Created attachment 391508 [details]
Floats with breakable and unbreakable content
Comment 10 zalan 2020-02-24 14:42:59 PST 
Created attachment 391581 [details]
Patch
Comment 11 WebKit Commit Bot 2020-02-24 16:57:20 PST 
The commit-queue encountered the following flaky tests while processing attachment 391581 [details]:

editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2020-02-24 16:57:47 PST 
The commit-queue encountered the following flaky tests while processing attachment 391581 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2020-02-24 17:42:52 PST 
Comment on attachment 391581 [details]
Patch

Clearing flags on attachment: 391581

Committed r257291: <https://trac.webkit.org/changeset/257291>
Comment 14 WebKit Commit Bot 2020-02-24 17:42:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 15 Fujii Hironori 2020-02-24 23:39:35 PST 
Committed r257297: <https://trac.webkit.org/changeset/257297>