Bug 208064 - [ews] Add build step to Validate ChangeLog for commit-queue
Summary: [ews] Add build step to Validate ChangeLog for commit-queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-21 10:36 PST by Aakash Jain
Modified: 2020-03-19 15:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.06 KB, patch)
2020-02-21 10:40 PST, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-02-21 10:36:00 PST
Add build step to Validate ChangeLog. This step would be required for commit-queue, to validate whether the ChangeLog looks fine (i.e. doesn't contains OOPS, the reviewer name in 'Reviewed by XYZ' is a valid reviewer).
Comment 1 Aakash Jain 2020-02-21 10:40:03 PST
Created attachment 391409 [details]
Patch
Comment 2 Aakash Jain 2020-02-21 10:41:05 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/698
Comment 3 Jonathan Bedard 2020-02-21 11:59:30 PST
(In reply to Aakash Jain from comment #2)
> Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/698

Do you have a successful example?
Comment 4 Aakash Jain 2020-02-21 12:14:39 PST
(In reply to Jonathan Bedard from comment #3)
> Do you have a successful example?
https://ews-build.webkit-uat.org/#/builders/26/builds/735
Comment 5 Aakash Jain 2020-02-21 13:12:06 PST
Committed r257157: <https://trac.webkit.org/changeset/257157>
Comment 6 Radar WebKit Bug Importer 2020-02-21 13:13:15 PST
<rdar://problem/59679885>
Comment 7 Aakash Jain 2020-03-19 15:07:18 PDT
This change seems to be working fine. e.g.:

ChangeLog missing Unreviewed/Reviewed-by text: https://ews-build.webkit.org/#/builders/28/builds/64

ChangeLog containing OOPS: https://ews-build.webkit.org/#/builders/28/builds/52