[GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14

[Lauro Moura]

[GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14

[Lauro Moura]

Created attachment 391376 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 391376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391376&action=review

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110
> +        gst_tag_list_unref(combinerPad->tags);

unref and then assign to nullptr, which is what clear is doing

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113
> +        gst_object_unref(combinerPad->funnelPad);

ditto

[Alicia Boya García]

Comment on attachment 391376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391376&action=review

>> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110
>> +        gst_tag_list_unref(combinerPad->tags);
> 
> unref and then assign to nullptr, which is what clear is doing

g_clear_pointer(&combinerPad->tags, gst_tag_list_unref);

>> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113
>> +        gst_object_unref(combinerPad->funnelPad);
> 
> ditto

g_clear_pointer(&combinerPad->funnelPad, gst_object_unref);

[Xabier Rodríguez Calvar]

(In reply to Alicia Boya García from comment #3)
> Comment on attachment 391376 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391376&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110
> >> +        gst_tag_list_unref(combinerPad->tags);
> > 
> > unref and then assign to nullptr, which is what clear is doing
> 
> g_clear_pointer(&combinerPad->tags, gst_tag_list_unref);
> 
> >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113
> >> +        gst_object_unref(combinerPad->funnelPad);
> > 
> > ditto
> 
> g_clear_pointer(&combinerPad->funnelPad, gst_object_unref);

👏🏼

I didn't remember this

[Lauro Moura]

Created attachment 391391 [details]
Patch

[Carlos Alberto Lopez Perez]

(In reply to Lauro Moura from comment #0)
> [GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14

In general I appreciate giving more pointers to when this started to happen in the bug description or at least adding the related bug in the see also field :)

[WebKit Commit Bot]

Comment on attachment 391391 [details]
Patch

Clearing flags on attachment: 391391

Committed r257133: <https://trac.webkit.org/changeset/257133>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59665227>