Bug 208037 - Add fidelity.com to the desktop class quirks list
Summary: Add fidelity.com to the desktop class quirks list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-20 16:09 PST by John Wilander
Modified: 2020-02-20 17:25 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2020-02-20 16:13 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch for landing (1.54 KB, patch)
2020-02-20 16:41 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2020-02-20 16:09:53 PST 
It seems fidelity.com is binding an event handler to both clicks and touches on its document and then only unbinding the click event. This leads to a broken experience when the browser supports both click and touch events. We should add fidelity.com to the desktop class quirks list until they can fix their website.
Comment 1 John Wilander 2020-02-20 16:12:40 PST 
<rdar://problem/59480381>
Comment 2 John Wilander 2020-02-20 16:13:37 PST 
Created attachment 391353 [details]
Patch
Comment 3 Brent Fulgham 2020-02-20 16:25:00 PST 
Comment on attachment 391353 [details]
Patch

Very sad. Can we paste the radar here so we can remove this once we get a site change?
Comment 4 John Wilander 2020-02-20 16:27:16 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 391353 [details]
> Patch
> 
> Very sad. Can we paste the radar here so we can remove this once we get a
> site change?

You mean like a FIXME in the code? Because the radar is above here on the Bugzilla.
Comment 5 Brent Fulgham 2020-02-20 16:32:53 PST 
(In reply to John Wilander from comment #4)
> (In reply to Brent Fulgham from comment #3)
> > Comment on attachment 391353 [details]
> > Patch
> > 
> > Very sad. Can we paste the radar here so we can remove this once we get a
> > site change?
> 
> You mean like a FIXME in the code? Because the radar is above here on the
> Bugzilla.

Yes. Just add a FIXME and reference the radar tracking the communication with Fidelity.
Comment 6 John Wilander 2020-02-20 16:34:24 PST 
Got it. Thanks!
Comment 7 John Wilander 2020-02-20 16:41:14 PST 
Created attachment 391358 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2020-02-20 17:25:37 PST 
Comment on attachment 391358 [details]
Patch for landing

Clearing flags on attachment: 391358

Committed r257106: <https://trac.webkit.org/changeset/257106>
Comment 9 WebKit Commit Bot 2020-02-20 17:25:38 PST 
All reviewed patches have been landed.  Closing bug.