RESOLVED FIXED 208021
[ews] Add build step to set cq- flag on bugzilla patch 
https://bugs.webkit.org/show_bug.cgi?id=208021
Summary [ews] Add build step to set cq- flag on bugzilla patch
Aakash Jain
Reported 2020-02-20 11:22:10 PST
Add build step to set cq- flag on bugzilla patch. This step would be required for commit-queue, when a patch fails validation (e.g.: ChangeLog contains OOPS, invalid Reviewer etc.)
Attachments
Patch (2.68 KB, patch)
2020-02-20 11:45 PST, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-02-20 11:45:58 PST
Created attachment 391315 [details] Patch
Jonathan Bedard
Comment 2 2020-02-20 13:02:47 PST
Comment on attachment 391315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391315&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:452 > + flags = [{'name': 'commit-queue', 'status': '-'}] Nit: Any reason to keep this on it's own line? It's only used on line 454, not sure that it makes things more clear.
Aakash Jain
Comment 3 2020-02-20 13:05:09 PST
Comment on attachment 391315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391315&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:452 >> + flags = [{'name': 'commit-queue', 'status': '-'}] > > Nit: Any reason to keep this on it's own line? It's only used on line 454, not sure that it makes things more clear. just for readability. line 454 would have become too long and hard to read with this info in it.
Aakash Jain
Comment 4 2020-02-21 10:24:44 PST
Committed r257147: <https://trac.webkit.org/changeset/257147>
Radar WebKit Bug Importer
Comment 5 2020-02-21 10:25:14 PST
<rdar://problem/59673032>
Note You need to log in before you can comment on or make changes to this bug.