Bug 208020 - [First paint] Let optional style recalcs go through while in visually-non-empty state.
Summary: [First paint] Let optional style recalcs go through while in visually-non-emp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-20 11:19 PST by zalan
Modified: 2020-02-20 19:40 PST (History)
11 users (show)

See Also:

Attachments
Patch (2.55 KB, patch)
2020-02-20 12:21 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.74 KB, patch)
2020-02-20 15:34 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.74 KB, patch)
2020-02-20 16:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-20 11:19:24 PST 
and only throttle layouts
Comment 1 Radar WebKit Bug Importer 2020-02-20 11:19:39 PST 
<rdar://problem/59636549>
Comment 2 zalan 2020-02-20 12:21:15 PST 
Created attachment 391318 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-02-20 12:59:40 PST 
Comment on attachment 391318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391318&action=review

> Source/WebCore/dom/Document.cpp:1875
>      auto shouldThrottleStyleRecalc = [&] {

Doesn't seem worth keeping this lambda now.

> Source/WebCore/dom/Document.cpp:3137
> +    if (view() && view()->isVisuallyNonEmpty())
>          return false;

So this prevents the zero-delay layout timer from firing?

So need to get rid of that timer. Maybe this kills it for all post-visually-empty states?
Comment 4 zalan 2020-02-20 15:34:45 PST 
Created attachment 391345 [details]
Patch
Comment 5 zalan 2020-02-20 16:57:57 PST 
Created attachment 391359 [details]
Patch
Comment 6 WebKit Commit Bot 2020-02-20 19:40:42 PST 
Comment on attachment 391359 [details]
Patch

Clearing flags on attachment: 391359

Committed r257126: <https://trac.webkit.org/changeset/257126>
Comment 7 WebKit Commit Bot 2020-02-20 19:40:44 PST 
All reviewed patches have been landed.  Closing bug.