RESOLVED FIXED Bug 208008
[First paint] FrameView::loadProgressingStatusChanged should check m_firstVisuallyNonEmptyLayoutMilestoneIsPending 
https://bugs.webkit.org/show_bug.cgi?id=208008
Summary [First paint] FrameView::loadProgressingStatusChanged should check m_firstVis...
zalan
Reported 2020-02-20 09:08:58 PST
and not m_contentQualifiesAsVisuallyNonEmpty
Attachments
Patch (1.61 KB, patch)
2020-02-20 09:49 PST, zalan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 for mac-mojave (3.66 MB, application/zip)
2020-02-20 12:56 PST, WebKit Commit Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-20 09:09:25 PST
<rdar://problem/59630957>
zalan
Comment 2 2020-02-20 09:49:01 PST
Created attachment 391296 [details] Patch
WebKit Commit Bot
Comment 3 2020-02-20 10:54:29 PST
The commit-queue encountered the following flaky tests while processing attachment 391296 [details]: editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) animations/cross-fade-list-style-image.html bug 208017 (authors: dino@apple.com and graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2020-02-20 10:55:03 PST
The commit-queue encountered the following flaky tests while processing attachment 391296 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-20 12:55:59 PST
Comment on attachment 391296 [details] Patch Rejecting attachment 391296 [details] from commit-queue. New failing tests: editing/spelling/spellcheck-paste-continuous-disabled.html Full output: https://webkit-queues.webkit.org/results/13325876
WebKit Commit Bot
Comment 6 2020-02-20 12:56:01 PST
Created attachment 391320 [details] Archive of layout-test-results from webkit-cq-03 for mac-mojave The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-mojave Platform: Mac OS X 10.14.6
WebKit Commit Bot
Comment 7 2020-02-20 14:59:30 PST
Comment on attachment 391296 [details] Patch Clearing flags on attachment: 391296 Committed r257094: <https://trac.webkit.org/changeset/257094>
WebKit Commit Bot
Comment 8 2020-02-20 14:59:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.