RESOLVED FIXED 207993
[Web Animations] Repeated animations on pseudo elements will fail to run after a while 
https://bugs.webkit.org/show_bug.cgi?id=207993
Summary [Web Animations] Repeated animations on pseudo elements will fail to run afte...
Simon Fraser (smfr)
Reported 2020-02-19 21:15:18 PST
[Web Animations] Repeating animations on pseudo elements will fail to run after a while
Attachments
Patch (3.37 KB, patch)
2020-02-19 21:17 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (11.21 KB, patch)
2020-02-20 16:38 PST, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Patch (13.77 KB, patch)
2020-02-20 21:15 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (13.77 KB, patch)
2020-02-20 21:18 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (13.97 KB, patch)
2020-02-20 21:29 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (13.99 KB, patch)
2020-02-21 08:09 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-02-19 21:17:57 PST
Created attachment 391255 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-02-19 21:17:59 PST
<rdar://problem/59428472>
Simon Fraser (smfr)
Comment 3 2020-02-19 21:18:31 PST
Comment on attachment 391255 [details] Patch Needs a test.
Simon Fraser (smfr)
Comment 4 2020-02-19 22:28:37 PST
The assertions appear to be incorrect because there's a call to timeline->elementWasRemoved() from RenderTreeUpdater::tearDownRenderers() which is not about Element destruction. Which means I don't know when it's OK to call m_elementToCSSAnimationsCreatedByMarkupMap.remove().
Antti Koivisto
Comment 5 2020-02-20 00:03:09 PST
Yeah, that doesn't make logical sense though may work in practice. I guess the idea is to do a full cleanup. It is only called when renderTreeBeingDestroyed() and that is only set during document destruction and when entering b/f cache. The latter case is suspicious but might be fine.
Simon Fraser (smfr)
Comment 6 2020-02-20 16:38:20 PST
Created attachment 391357 [details] Patch
Dean Jackson
Comment 7 2020-02-20 19:38:04 PST
Comment on attachment 391357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391357&action=review > Source/WebCore/animation/AnimationTimeline.cpp:227 > +void AnimationTimeline::willDestoryRendererForElement(Element& element) destroy typo
Simon Fraser (smfr)
Comment 8 2020-02-20 21:15:06 PST
Created attachment 391379 [details] Patch
Simon Fraser (smfr)
Comment 9 2020-02-20 21:18:10 PST
Created attachment 391380 [details] Patch
Simon Fraser (smfr)
Comment 10 2020-02-20 21:29:11 PST
Created attachment 391381 [details] Patch
Simon Fraser (smfr)
Comment 11 2020-02-21 08:09:26 PST
Created attachment 391398 [details] Patch
WebKit Commit Bot
Comment 12 2020-02-21 09:21:51 PST
Comment on attachment 391398 [details] Patch Clearing flags on attachment: 391398 Committed r257138: <https://trac.webkit.org/changeset/257138>
Antoine Quint
Comment 13 2020-06-24 09:44:07 PDT
*** Bug 213547 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.