Bug 207985 – [WebAuthn] Replace DeviceIdentity.framework

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

Adopt Apple attestation.

[Jiewen Tan]

<rdar://problem/59369223>

[Jiewen Tan]

Created attachment 391254 [details]
Patch

[Jiewen Tan]

Comment on attachment 391254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:312
> +        WTFLogAlways("Couldn't attest: %@", error);

Should actually be LOG_ERROR.

[Brent Fulgham]

Comment on attachment 391254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review

r=me

> Source/WebKit/ChangeLog:10
> +        Invocations of the new framework is hidden in WKA. Please refer to the radar for detailed information.

"The new experimental authentication logic is handled by WebKtAdditions. Please refer to the radar for detailed information."

> Source/WebKit/ChangeLog:13
> +        1) changes the way how user consent is obtained such that biometrics will not be prompted twice.

changes how user consent is obtained to avoid multiple prompts for biometric input.

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:174
>          "allow " + creationOptions.rp.id + " to create a public key credential for " + creationOptions.user.name,

Should this be "makeString("allow "_s, creationOptions.rp.id, " to create a public key credential for"_s, creationOptions.user.name)

[Jiewen Tan]

Comment on attachment 391254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review

Thanks Brent for r+ the patch.

>> Source/WebKit/ChangeLog:10
>> +        Invocations of the new framework is hidden in WKA. Please refer to the radar for detailed information.
> 
> "The new experimental authentication logic is handled by WebKtAdditions. Please refer to the radar for detailed information."

Fixed.

>> Source/WebKit/ChangeLog:13
>> +        1) changes the way how user consent is obtained such that biometrics will not be prompted twice.
> 
> changes how user consent is obtained to avoid multiple prompts for biometric input.

Fixed.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:174
>>          "allow " + creationOptions.rp.id + " to create a public key credential for " + creationOptions.user.name,
> 
> Should this be "makeString("allow "_s, creationOptions.rp.id, " to create a public key credential for"_s, creationOptions.user.name)

Yes.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:312
>> +        WTFLogAlways("Couldn't attest: %@", error);
> 
> Should actually be LOG_ERROR.

Fixed.

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h:38
> +namespace WebCore {

Not needed.

[Jiewen Tan]

Created attachment 391321 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 391321 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 391321 [details]
Patch for landing

Clearing flags on attachment: 391321

Committed r257085: <https://trac.webkit.org/changeset/257085>