Bug 207967 – Resources larger than 10MB are not stored in the disk cache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Resources larger than 10MB are not stored in the disk cache.

[Chris Dumez]

<rdar://problem/59572084>

[Chris Dumez]

Created attachment 391206 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 391206 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 391206 [details]
Patch

Clearing flags on attachment: 391206

Committed r257041: <https://trac.webkit.org/changeset/257041>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antti Koivisto]

Comment on attachment 391206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391206&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:588
> -        // Prevent memory growth in case of streaming data.
> -        const size_t maximumCacheBufferSize = 10 * 1024 * 1024;
> +        // Prevent memory growth in case of streaming data and limit size of entries in the cache.
> +        const size_t maximumCacheBufferSize = m_cache->capacity() / 8;

If the capacity computes to less than the 80MB this will reduce the maximum size. Can that be a problem?

> Source/WebKit/Shared/CacheModel.cpp:188
> -            urlCacheDiskCapacity = 500 * MB;
> +            urlCacheDiskCapacity = 1 * GB;

Maybe also increment DocumentBrowser cache model similarly?