Bug 207966 - [First paint] Introduce FrameView::m_firstVisuallyNonEmptyLayoutMilestoneIsPending
Summary: [First paint] Introduce FrameView::m_firstVisuallyNonEmptyLayoutMilestoneIsPe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-19 14:38 PST by zalan
Modified: 2020-02-19 16:48 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.26 KB, patch)
2020-02-19 14:43 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (4.25 KB, patch)
2020-02-19 15:59 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-19 14:38:33 PST
to indicate that we've got a pending callback and we have to issue this callback soon after the content turns into visually non-empty.
Comment 1 Radar WebKit Bug Importer 2020-02-19 14:38:51 PST
<rdar://problem/59606528>
Comment 2 zalan 2020-02-19 14:43:49 PST
Created attachment 391203 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-02-19 15:10:11 PST
Comment on attachment 391203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391203&action=review

> Source/WebCore/page/FrameView.cpp:5144
> +            addPaintPendingMilestones(DidFirstMeaningfulPaint);

I"m sad that we're giving up on the distinction between "first contentful paint" and "first meaningful paint". How does "relevant repainted objects" threshold fit into this?

> Source/WebCore/page/FrameView.h:924
> +    bool m_contentIsQualifiedAsVisuallyNonEmpty { false };
> +    bool m_firstVisuallyNonEmptyLayoutCallbackPending { true };

Maybe collapse these two into a "state" enum.

If not, please be consistent with naming. Maybe "contentIsQualified" -> qualifiesAs, and m_firstVisuallyNonEmptyLayoutCallbackPending -> m_didFirstMeaningfulPaintMilestone pending
Comment 4 zalan 2020-02-19 15:57:13 PST
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 391203 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391203&action=review
> 
> > Source/WebCore/page/FrameView.cpp:5144
> > +            addPaintPendingMilestones(DidFirstMeaningfulPaint);
> 
> I"m sad that we're giving up on the distinction between "first contentful
> paint" and "first meaningful paint". How does "relevant repainted objects"
> threshold fit into this?
I think it's more accurate to say that we don't even have the clear distinction yet.

> 
> > Source/WebCore/page/FrameView.h:924
> > +    bool m_contentIsQualifiedAsVisuallyNonEmpty { false };
> > +    bool m_firstVisuallyNonEmptyLayoutCallbackPending { true };
> 
> Maybe collapse these two into a "state" enum.
> 
> If not, please be consistent with naming. Maybe "contentIsQualified" ->
> qualifiesAs, and m_firstVisuallyNonEmptyLayoutCallbackPending ->
> m_didFirstMeaningfulPaintMilestone pending
I'll do that.
Comment 5 zalan 2020-02-19 15:59:22 PST
Created attachment 391213 [details]
Patch
Comment 6 WebKit Commit Bot 2020-02-19 16:48:13 PST
Comment on attachment 391213 [details]
Patch

Clearing flags on attachment: 391213

Committed r256999: <https://trac.webkit.org/changeset/256999>
Comment 7 WebKit Commit Bot 2020-02-19 16:48:15 PST
All reviewed patches have been landed.  Closing bug.