to indicate that we've got a pending callback and we have to issue this callback soon after the content turns into visually non-empty.
<rdar://problem/59606528>
Created attachment 391203 [details] Patch
Comment on attachment 391203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391203&action=review > Source/WebCore/page/FrameView.cpp:5144 > + addPaintPendingMilestones(DidFirstMeaningfulPaint); I"m sad that we're giving up on the distinction between "first contentful paint" and "first meaningful paint". How does "relevant repainted objects" threshold fit into this? > Source/WebCore/page/FrameView.h:924 > + bool m_contentIsQualifiedAsVisuallyNonEmpty { false }; > + bool m_firstVisuallyNonEmptyLayoutCallbackPending { true }; Maybe collapse these two into a "state" enum. If not, please be consistent with naming. Maybe "contentIsQualified" -> qualifiesAs, and m_firstVisuallyNonEmptyLayoutCallbackPending -> m_didFirstMeaningfulPaintMilestone pending
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 391203 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391203&action=review > > > Source/WebCore/page/FrameView.cpp:5144 > > + addPaintPendingMilestones(DidFirstMeaningfulPaint); > > I"m sad that we're giving up on the distinction between "first contentful > paint" and "first meaningful paint". How does "relevant repainted objects" > threshold fit into this? I think it's more accurate to say that we don't even have the clear distinction yet. > > > Source/WebCore/page/FrameView.h:924 > > + bool m_contentIsQualifiedAsVisuallyNonEmpty { false }; > > + bool m_firstVisuallyNonEmptyLayoutCallbackPending { true }; > > Maybe collapse these two into a "state" enum. > > If not, please be consistent with naming. Maybe "contentIsQualified" -> > qualifiesAs, and m_firstVisuallyNonEmptyLayoutCallbackPending -> > m_didFirstMeaningfulPaintMilestone pending I'll do that.
Created attachment 391213 [details] Patch
Comment on attachment 391213 [details] Patch Clearing flags on attachment: 391213 Committed r256999: <https://trac.webkit.org/changeset/256999>
All reviewed patches have been landed. Closing bug.