Bug 207964 - Avoid preconnecting to custom URL schemes
Summary: Avoid preconnecting to custom URL schemes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-19 14:30 PST by Ben Nham
Modified: 2020-02-19 17:12 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2020-02-19 16:03 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2020-02-19 16:17 PST, Ben Nham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2020-02-19 14:30:25 PST 
NetworkProcess::preconnectTo preconnects to custom URL schemes, while NetworkConnectionToWebProcess::preconnectTo does not. The former's behavior should match the latter's.

This will also fix the debug test failures in TestWebKitAPI.WebKit.DownloadNavigationResponseFromMemoryCache and TestWebKitAPI.ContentFiltering.LazilyLoadPlatformFrameworks introduced by https://bugs.webkit.org/show_bug.cgi?id=207777. The reason for the debug test failure is that both of these tests register a custom HTTP scheme handler, and the scheme handlers are returning responses to the preconnect request which is causing the assert in PreconnectTask::didReceiveResponse to fire.
Comment 1 Radar WebKit Bug Importer 2020-02-19 14:30:57 PST 
<rdar://problem/59606178>
Comment 2 Ben Nham 2020-02-19 16:03:23 PST 
Created attachment 391214 [details]
Patch
Comment 3 Ben Nham 2020-02-19 16:17:13 PST 
Created attachment 391217 [details]
Patch
Comment 4 WebKit Commit Bot 2020-02-19 17:12:31 PST 
Comment on attachment 391217 [details]
Patch

Clearing flags on attachment: 391217

Committed r257008: <https://trac.webkit.org/changeset/257008>
Comment 5 WebKit Commit Bot 2020-02-19 17:12:33 PST 
All reviewed patches have been landed.  Closing bug.