Bug 207954 - [ Mac wk2 ] http/tests/inspector/network/har/har-page.html is flaky failing
Summary: [ Mac wk2 ] http/tests/inspector/network/har/har-page.html is flaky failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac macOS 10.14
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-19 11:54 PST by Jason Lawrence
Modified: 2020-06-16 00:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.29 KB, patch)
2020-06-15 18:00 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (6.56 KB, patch)
2020-06-15 18:50 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Lawrence 2020-02-19 11:54:12 PST
http/tests/inspector/network/har/har-page.html 

Description:
This test is flaky failing throughout the visible history on Mac wk2. The diff has changed several times throughout the history, I cannot find another recent failure before this with this same diff. The most recent failure with a different diff is r256914.

History:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html&limit=50000&platform=mac&flavor=wk2

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -104,9 +104,7 @@
           "send": "<filtered>",
           "wait": "<filtered>",
           "receive": "<filtered>"
-        },
-        "_serverPort": 8000,
-        "_priority": "high"
+        }
       },
       {
         "pageref": "page_0",
Comment 1 Radar WebKit Bug Importer 2020-02-19 11:54:38 PST
<rdar://problem/59599895>
Comment 2 Jason Lawrence 2020-02-19 11:58:25 PST
I have marked this test as failing while this issue is investigated.
https://trac.webkit.org/changeset/256931/webkit
Comment 3 Jason Lawrence 2020-02-19 14:02:51 PST
I can reproduce this issue with r256933 using the command below.
run-webkit-tests http/tests/inspector/network/har/har-page.html --iterations 4000 --exit-after-n-failures 5 -f --force

[5/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
[9/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
[10/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
[11/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
[12/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
Exiting early after 5 failures. 9 tests run.

4 tests ran as expected, 5 didn't (3991 didn't run):
Comment 4 Ryan Haddad 2020-04-08 17:28:16 PDT
This test went from failing a few times a day to failing almost consistently with or around https://trac.webkit.org/changeset/259009/webkit

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -87,7 +87,7 @@
           "headers": "<filtered>",
           "content": {
             "size": "<filtered>",
-            "compression": 0,
+            "compression": 7240,
             "mimeType": "application/x-javascript",
             "text": "<filtered>"
           },
@@ -104,9 +104,7 @@
           "send": "<filtered>",
           "wait": "<filtered>",
           "receive": "<filtered>"
-        },
-        "_serverPort": 8000,
-        "_priority": "high"
+        }
       },
       {
         "pageref": "page_0",
@@ -130,7 +128,7 @@
           "headers": "<filtered>",
           "content": {
             "size": "<filtered>",
-            "compression": 0,
+            "compression": 7472,
             "mimeType": "application/x-javascript",
             "text": "<filtered>"
           },
@@ -147,9 +145,7 @@
           "send": "<filtered>",
           "wait": "<filtered>",
           "receive": "<filtered>"
-        },
-        "_serverPort": 8000,
-        "_priority": "high"
+        }
       },
       {
         "pageref": "page_0",
Comment 5 Devin Rousso 2020-06-15 18:00:36 PDT
Created attachment 401962 [details]
Patch
Comment 6 Devin Rousso 2020-06-15 18:50:39 PDT
Created attachment 401968 [details]
Patch

lol the expected file for "har-page-aggressive-gc.html" had a title of "har-page.html" 🤣
Comment 7 Maciej Stachowiak 2020-06-16 00:13:08 PDT
Comment on attachment 401968 [details]
Patch

r=me
Comment 8 EWS 2020-06-16 00:19:01 PDT
Committed r263078: <https://trac.webkit.org/changeset/263078>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401968 [details].