Bug 207950 – Add support for AudioSession handling in GPUProcess for capture

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add support for AudioSession handling in GPUProcess for capture

[youenn fablet]

Created attachment 391179 [details]
Patch

[youenn fablet]

Created attachment 391205 [details]
Patch

[youenn fablet]

Created attachment 391207 [details]
Patch

[Eric Carlson]

Comment on attachment 391207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391207&action=review

> Source/WebCore/ChangeLog:10
> +        Use this new interface fo MediaStreamTrack capture sources.

s/fo/to/

[Eric Carlson]

Comment on attachment 391207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391207&action=review

> Source/WebCore/ChangeLog:17
> +        This includes BaseAudioSharedUnit, for which we add a audioUnitWillStart callback so that we compute the right AudioSession category before starting the capture.

Nit: please wrap this line, it is quite long.

[youenn fablet]

Created attachment 391225 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 391225 [details]
Patch for landing

Rejecting attachment 391225 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 391225, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13325266

[youenn fablet]

Created attachment 391227 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 391227 [details]
Patch for landing

Rejecting attachment 391227 [details] from commit-queue.

New failing tests:
editing/spelling/spellcheck-async-remove-frame.html
Full output: https://webkit-queues.webkit.org/results/13325288

[WebKit Commit Bot]

Created attachment 391242 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-mojave  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 391227 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 391227 [details]
Patch for landing

Clearing flags on attachment: 391227

Committed r257039: <https://trac.webkit.org/changeset/257039>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59616466>