Bug 207937 – [LFC][Floats] FloatingContext::constraints should be able to handle empty candidate ranges (points)

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

when the candidate range is empty.

[Radar WebKit Bug Importer]

<rdar://problem/59591109>

[zalan]

Created attachment 391165 [details]
Patch

[Antti Koivisto]

Comment on attachment 391165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391165&action=review

> Source/WebCore/layout/floats/FloatingContext.cpp:308
> +                return floatBoxRect.top() <= adjustedCandidateTop && floatBoxRect.bottom() > adjustedCandidateTop;
> +            return !(floatBoxRect.top() >= adjustedCandidateBottom || floatBoxRect.bottom() <= adjustedCandidateTop);

The difference between these would be clearer if the logic was the same way round (that is no !)

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 391165 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391165&action=review
> 
> > Source/WebCore/layout/floats/FloatingContext.cpp:308
> > +                return floatBoxRect.top() <= adjustedCandidateTop && floatBoxRect.bottom() > adjustedCandidateTop;
> > +            return !(floatBoxRect.top() >= adjustedCandidateBottom || floatBoxRect.bottom() <= adjustedCandidateTop);
> 
> The difference between these would be clearer if the logic was the same way
> round (that is no !)
sure.

[zalan]

Created attachment 391173 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 391173 [details]
Patch

Clearing flags on attachment: 391173

Committed r256928: <https://trac.webkit.org/changeset/256928>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.